Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

update 'nested' to 'details' #27

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

gregsdennis
Copy link
Member

@gregsdennis gregsdennis commented Nov 21, 2022

Updating per json-schema-org/json-schema-spec#1351

Ref: json-schema-org/json-schema-spec#1347

Question: Do I need to add an "edited" comment at the end to log the change? What's the policy on the blog?

@gregsdennis
Copy link
Member Author

gregsdennis commented Nov 23, 2022

This post doesn't include any information on dropping detailed and renaming verbose -> hierarchical. The focus seems to be more on the changes in structure than on the formats themselves.

I'm not sure that it's necessary (for this post) to update it to mention the name changes for the formats. Ref: json-schema-org/json-schema-spec#1351

@handrews
Copy link

handrews commented Nov 24, 2022

Maybe add a line somewhere that the structural changes here will be formats under new names (you can list the names or not) just so folks have a heads-up that the existing formats aren't expected to be changed (just deprecated/dropped)? But really, I'm fine with you leaving it as-is if you prefer, so consider my "approved" to still hold. As far as I'm concerned you can merge this anytime as the spec change doesn't have to be in first.

@gregsdennis
Copy link
Member Author

I prefer waiting until the spec is updated.

@gregsdennis gregsdennis merged commit 21dcc51 into main Dec 6, 2022
@gregsdennis gregsdennis deleted the gregsdennis/output-nested-to-details branch December 6, 2022 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants