Add tests for not: {} schemas for all values. #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One would think these would be quite trivial tests... but not all implementations pass them surprisingly! This was noticed as part of tweaking Bowtie's smoke test for implementations (bowtie-json-schema/bowtie@3984ef6#diff-dc32c0287345ff144e16658c5c157495f1c3c3f46c71dd3a58b2414663dcd08aR450-R458) -- which it uses to make sure JSON Schema implementations are running correctly -- in what I thought was a non-functionally meaningful way. But it turns out one implementation fails one of these tests :) -- namely it incorrectly considers `null` valid under `not: {}`. The actual contents here match what we use in other places (e.g. in boolean-schemas.json). While we're here, this also adds a test for not: not, i.e. double negation, with just one value to check.
jdesrosiers
approved these changes
Jan 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests that essentially say all instances are valid under
"not": falseand all are invalid under"not": trueand"not": {}.One would think these would be quite trivial tests... but not all implementations pass them surprisingly!
This was noticed as part of tweaking Bowtie's smoke test for implementations -- which it uses to make sure JSON Schema implementations are running correctly -- in what I thought was a non-functionally meaningful way.
But it turns out one implementation fails one of these tests :) -- namely it incorrectly considers
nullvalid undernot: {}.The actual contents here match what we use in other places (e.g. in boolean-schemas.json).
While we're here, this also adds a test for not: not, i.e. double negation, with just one value to check.