Remove unnecessary type validation from unevaluatedItems tests. #566
+22
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
reviewed
Jun 30, 2022
| { | ||
| "unevaluatedItems": false | ||
| } | ||
| { "unevaluatedItems": false } |
There was a problem hiding this comment.
We really need to define a formatting style and apply it to the whole suite.... eventually.
There was a problem hiding this comment.
Agree, and I lamented it when doing this but I figured it'd be pretty uncontentious for this specific case :D.
For "real life" schemas, this is likely the desired behavior, but in these tests it's not what's being tested (no results depend on it) and essentially is just extra schema noise.
Julian
force-pushed
the
tidy-unevaluatedItems
branch
from
c268421 to
b45a787
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For "real life" schemas, this is likely the desired behavior, but in
these tests it's not what's being tested (no results depend on it) and
essentially is just extra schema noise.