tests for the "uuid" format #401
Conversation
| "valid": false | ||
| }, | ||
| { | ||
| "description": "bad characters", |
There was a problem hiding this comment.
Maybe "non-hex" is a bit clearer if that's what this one is trying to test, seems so?
| "valid": false | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Also also probably good to have a UUID 6 (i.e. by inserting 6 where the version goes) and assert it's invalid?
There was a problem hiding this comment.
good call. I've seen some regexes that are tighter and only accept the current versions, but indeed the RFC says
Apart from determining whether the timestamp portion of the UUID is in the future and therefore not yet assignable, there is no mechanism for determining whether a UUID is 'valid'.
..so these implementations are being needlessly (and invalidly) too strict.
There was a problem hiding this comment.
invalid, or valid? IMO we should accept future versions as well.
There was a problem hiding this comment.
fwiw I just tried a "future version" uuid in PostgreSQL against its uuid data type and it accepted version 6 and version 15 (f).
There was a problem hiding this comment.
Cool, yep good catch (I didn't go read the RFC first, so yeah seems valid is the right behavior)!
tests for the "uuid" format
No description provided.