Skip to content

Check uniqueItems with array items #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Oct 1, 2019

Closes #279.

@Zac-HD Zac-HD force-pushed the unique-array-of-items branch from 6ce78f0 to 7c20615 Compare October 1, 2019 14:16
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the files are changed the same as for draft-2019-09, this looks good to go in my books.

The tests are failing for unrelated reasons.
Oh, looks like it's fixed.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the files are changed the same as for draft-2019-09, this looks good to go in my books.

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Oct 1, 2019

Yep, they're all identical. The failing tests were actually because I'd accidentally repeated a test-case description, not because of the new format keywords 😅

@Relequestual
Copy link
Member

Force restarted the CI job so the link works correctly!

@Julian Julian merged commit b6f79ee into json-schema-org:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests with type=array, items=[a list of schemas], and uniqueItems=true
3 participants