Resubmitting... #24
Merged
Resubmitting... #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Regex matches are not anchored. * Matching is case insensitive.
The only test was to recognize a number as an integer. Add a test to check a mathematical operation on such a numer. And take a float.
Add a very bizarre construct which only ECMA 262 allows in regexes. Check that lookbehinds are _not_ supported.
|
Hey. Looks good to me but I'm so confused... Is your JSON-Schema-Test-Suite repo private / deleted or is GitHub misbehaving? Where are these commits, https://github.com/fge/JSON-Schema-Test-Suite is a 404 for me. |
|
Yes, I have deleted it. I will recreate it and redo them again. |
|
Looks good to me as well. I'd rather leave @Julian to confirm the merge, though - you're more authoritative on the test suite than I am. |
|
Hey, OK no problem, I'll just use the big green button. I usually like merging manually and I'd pull this into develop but it's not really worth the extra work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder where github went wrong but anyway.
Contents are the same. Non anchored regexes, math op on big num, ECMA 262 regex conformance.