test: run draft-04/06 tests with ajv

[epoberezkin]

@Julian with this it runs the tests with both python and javascript, so draft-06 tests are tested and draft-04 are tested twice.

[handrews]

Looks good to me, although my JavaScript knowledge is very outdated. @tajo can you take a quick look? Ajv is the validator I was suggesting we use in doca as we move to Draft 06, btw.

[Julian]

This is fine with me too (other than a minor note about the gitignore).

And by the way, I still can add support for the Python library as soon as we've published a meta schema somewhere permanent, so if we've done that, I'd be happy to as well.

[Julian]

The intention here is that all this belongs in your global gitignore, since all this stuff should be ignored across all repos.

[epoberezkin]

@Julian so, just remove all this stuff from .gitignore then and leave it as TODO? Or am I missing something?

[Julian]

Yeah exactly, unless there's anything specifically that needs ignoring in this repo, but not necessarily in all others.

(So for example, *.py[co] is not specific to this repo, those files should be ignored everywhere, in all repos. If you haven't seen it before by the way, my own global gitignore for example contains: https://github.com/Julian/dotfiles/blob/master/.config/git/ignore)

[epoberezkin]

Interesting. I usually just agree with whatever .gitignore GitHub creates (which is what I've added). In this way if people don't have a global one, they won't accidentally commit some wrong stuff. No problem though, I will remove. Should we at least keep ".tox" and "node_modules" there? They are created after running tests.

[epoberezkin]

@Julian removed the change in .gitignore, if anything it should be a separate PR

[epoberezkin]

@Julian is it ok to merge? I've updated to run draft-4/6 correctly.

[Julian]

Yeah good with me! Merge away.

…

On Mar 12, 2017 15:01, "Evgeny Poberezkin" ***@***.***> wrote: @Julian <https://github.com/Julian> is it ok to merge? I've updated to run draft-4/6 correctly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#169 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUIXp71o-0Mzx-tOCKgtEWjUE4lgki5ks5rlEEYgaJpZM4MPbYe> .