Extract the schema for tests into a JSON file.

[seagreen]

No description provided.

[seagreen]

Will fix this issue: #94

Is the way I read the file to JSON idiomatic?

[Julian]

Needs a with statement to not leave the file descriptor hanging around.

[Julian]

Also would be good to use a path relative to __file__ rather than relative to cwd.

[Julian]

Awesome! Thanks so much. Left 2 comments, lemme know if they're clear.

[seagreen]

How does that look? (force pushed)

[Julian]

Why did you choose to add a function just to call it once right after :)?

Sorry, I'm annoying :)

[seagreen]

Sorry, I'm annoying :)

Not at all, I'm enjoying the chance to re-learn some python.

Using with gave me this error SyntaxError: invalid syntax.

It happens whether I put everything on one line

TESTSUITE_SCHEMA = with open(os.path.join(ROOT_DIR, "test-schema.json")) as schema: return json.load(schema)

Or two (the indentation of this is showing off -- I have the return indented 4 spaces after the with):

TESTSUITE_SCHEMA = with open(os.path.join(ROOT_DIR, "test-schema.json")) as schema:
                                              return json.load(schema)

Doesn't the value of an assignment have to be an expression, not a statement? That would explain the problem.

[Julian]

Ah! Yes, it's a statement, which means you need to move the assignment within its body, e.g.:

with open(...) as test_schema:
    TESTSUITE_SCHEMA = json.load(test_schema)

[seagreen]

Ohhhhhhhhhh!

(Force pushed again)

[Julian]

Looks great! Thanks!