Skip to content

fix package.json main file #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

mathroc
Copy link
Contributor

@mathroc mathroc commented Jun 27, 2016

When I tried to include 'angular-schema-form' (import schemaForm from 'angular-schema-form';) it would produce this error when trying to "compile" it with webpack:

Module not found: Error: Cannot resolve module 'angular-schema-form/schema-form' in /scripts/src

It can be work-around like this until this is fixed here:

import schemaForm from 'angular-schema-form/dist/schema-form';

dist/schema-form.es5.js does not exists
@mathroc
Copy link
Contributor Author

mathroc commented Jun 27, 2016

in fact for workflows with es6 transpilers, I wonder if it would not be best to provide a index.js with the appropriate imports (angular, tv4, angular and src/*)

edit: never mind, I had forgotten Babel does not tries to transpile sources from node_modules/


and in any case the required runtime dependencies should be added as "dependencies" instead of "devDependencies"

thoughts ?

@Anthropic Anthropic merged commit b433055 into json-schema-form:feature/webpack-babel Jul 7, 2016
@Anthropic
Copy link
Member

@mathroc the devDependencies should be compiled into the final output while the dependencies are not, which dependencies are not included? json-schema-form-core is embedded by babel so it is not required on a prod system independently. Don't believe anything else is required.

@mathroc mathroc deleted the patch-1 branch July 7, 2016 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants