-
Notifications
You must be signed in to change notification settings - Fork 647
Revalidate model after successful custom validation event broadcasted #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revalidate model after successful custom validation event broadcasted #642
Conversation
…ustom_validation Revalidate model after successful custom validation event broadcasted
Thanks! |
@cepauskas, no, thank you for your efforts to help, the more the better, sorry it took so long we are going through some changes and there will be major updates to this framework in the not too distant future :) |
Hi guys. |
Do you configure properly form? You have to set ngModelOptions: { allowInvalid: true }, that custom error broadcasting would work.
|
sorry I miss-understand your exemple. I'm using asyncValidator on the field. |
It would be great if you could create a new release for this fix. When do you plan to get it out? Thx |
@raoulus I will do a build this weekend. |
I wanted to know the code better myself first, and finally look like having some time. :) |
Cool, looking forward! |
@Anthropic what about the release? :) |
@raoulus another pull I accepted had another pull added and I needed some clarification on the previous steps taken for this project, so it had to wait, but it will be this week/weekend :) |
@raoulus @cepauskas 0.8.13 is now in bower and the npm release will follow by tomorrow |
Description
Custom validation of input fails if event of successful validation is broadcasted after input validation is executed in onChange method (for example custom validation takes some time - timeout, async request etc.).
Reproduce
Enter "yzy" as name, wait a second till custom validation with timeout will ran (you will get "exists" error message). Enter one more character wait one more second. Input will be marked as invalid although it is valid.
https://jsfiddle.net/t1a8nhop/
Fix relates with issues
#577
#637
#440