Skip to content

Add js license info for example page. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2015
Merged

Add js license info for example page. #311

merged 3 commits into from
Mar 23, 2015

Conversation

albsod
Copy link

@albsod albsod commented Mar 20, 2015

This is a follow-up to #257.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.22% when pulling fec5963 on albsod:development into 24357d6 on Textalk:development.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.22% when pulling ea0627d on albsod:development into 24357d6 on Textalk:development.

</div>
<script type="text/javascript" src="http://code.jquery.com/jquery-2.1.1.min.js"></script>
<script type="text/javascript" src="http://cdn.jsdelivr.net/g/jquery.ui@1.10"></script>
<script type="text/javascript" src="https://code.jquery.com/jquery-2.1.1.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you changed these to https? https can cause up to 5x slower load, and i personally don't see a reason that one would need to load these over https, its jquery.

I can see a case for using :// instead as that would remove it being blocked when going to browsing the https:// site.

@albsod
Copy link
Author

albsod commented Mar 21, 2015

Personally, I always try to use HTTPS when possible. For me it's like turning the lights off when leaving a room. I wasn't aware of the speed difference though and I suppose there is no harm in using HTTP for the jquery URLs.

"I can see a case for using :// instead as that would remove it being blocked when going to browsing the https:// site."

OK, I'll change all the URLs to that.

@Dervisevic
Copy link
Contributor

Sorry it's actually // not ://

On Sun, Mar 22, 2015 at 12:03 AM, albsod notifications@github.com wrote:

Personally, I always try to use HTTPS when possible. For me it's like turning the lights off when leaving a room. I wasn't aware of the speed difference though and I suppose there is no harm in using HTTP for the jquery URLs.
"I can see a case for using :// instead as that would remove it being blocked when going to browsing the https:// site."

OK, I'll change all the URLs to that.

Reply to this email directly or view it on GitHub:
#311 (comment)

@Dervisevic Dervisevic closed this Mar 23, 2015
@Dervisevic Dervisevic reopened this Mar 23, 2015
Dervisevic added a commit that referenced this pull request Mar 23, 2015
Add js license info for example page.
@Dervisevic Dervisevic merged commit 2bf932c into json-schema-form:development Mar 23, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.22% when pulling 72e66cb on albsod:development into 24357d6 on Textalk:development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants