Support HTML in titles and descriptions #14
Conversation
… description. Updated tests for this. Updated bootstrap examples.
| @@ -5,8 +5,8 @@ | |||
| ng-model="$$value$$" | |||
| schema-validate="form.schema" | |||
| ng-required="form.required"> | |||
| {{form.title}} | |||
| <div ng-bind-html="form.title"></div> | |||
There was a problem hiding this comment.
Div is not a good choice here. Even if title would contain HTML code, a span would be more reasonable with title.
From json-schema definition: "A title will preferrably be short"
and about div in label:
http://stackoverflow.com/questions/18609554/is-div-inside-label-block-correct
There was a problem hiding this comment.
I actually had this discussion with @davidlgj. The reason we landed on div was due to us feeling it needed to be a block element, mainly due to stuff like line breaks or other things that semantically should not be in a inline element like a span. Thoughts?
There was a problem hiding this comment.
I'd say that a title should never contain block level elements. A description could, but description is never put in a label here what I can see.
Technically, you can't be sure of what the user puts in the title, but if they make the title block-level, they deserve broken html ;)
Support HTML in titles and descriptions
Changed so that some types(Like radiobuttons, checkboxes etc) can have HTML in title. Changed so that all can have it in description. Updated tests for this. Updated bootstrap examples to feature these changes.