Skip to content

Jeton's interpolation provider #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2014

Conversation

jeton
Copy link
Contributor

@jeton jeton commented Oct 7, 2014

Relating to my previously stated issue (#115) I have edited the template files, removing all references to hardcoded interpolation markup. I have also create a directive to be able to set a type and placeholder attrs of an input field without the need to for interpolation markup (default.html).

MattRawson added 2 commits October 7, 2014 18:17
…files.

- Created default-input.js as a workaround to set placeholder and type attributes.
davidlgj added a commit that referenced this pull request Oct 14, 2014
@davidlgj davidlgj merged commit 2b9d7b5 into json-schema-form:master Oct 14, 2014
@davidlgj
Copy link
Contributor

Hi @jeton Nice PR!

The only thing that's bothering me a bit is the directive that sets type and placeholder, it creates an isolated scope and some more watches for one simple change. I might give it a try to optimize that a bit later.

@davidlgj
Copy link
Contributor

Oh my bad, your PR was to master branch! I had to revert it. We do all new development into the "development" branch, following "git flow" (man I really need to move that higher up in the readme, your not the first making PR's agains master)

@dimamarkus
Copy link

What ever happened to this code? I can't seem to pull down any branch that contains it. Did it ever make it to the development?

@davidlgj
Copy link
Contributor

No it did not. Basically it's not the right solution either, not using expressions cripples us alot. And will be hard to enforce on third party add-ons. Especially when moving to bind once variants found in Angular 1.3.

A better solution is to search and replace {{}} in the templates with something else and use the $interpolatipnProvider

@zwiy
Copy link

zwiy commented Apr 7, 2017

Is there any new solution for this problem/issue? Or is it better to search and replace?

@Anthropic
Copy link
Member

@zwiy not aware of any other options sorry.

@vishnucr
Copy link

vishnucr commented Jul 4, 2017

how can i replace {{ }} interpolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants