Skip to content

Fix a number of bower issues #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 3, 2014
Merged

Fix a number of bower issues #107

merged 6 commits into from
Oct 3, 2014

Conversation

mike-marcacci
Copy link
Contributor

There were several missing dev dependencies for the examples (and possibly the tests). This also (redundantly) does the same as @morrislaptop's PR #106 and updates the angular dependency to support complex keys.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c2ba7ad on mike-marcacci:development into 681e5d4 on Textalk:development.

@davidlgj
Copy link
Contributor

davidlgj commented Oct 2, 2014

I'm not using bower to install schema form myself, but wouldn't this force people to use angular 1.3? Its recommended to use 1.3 but not a requirement. Thats why I did >=1.2 from the beginning.

I'm not very good at bower but is there a way to still allow 1.2 but install 1.3 as default?

@mike-marcacci
Copy link
Contributor Author

@davidlgj you may be correct here – I'll investigate a bit further. I'm under the impression that bower only follows the "resolutions" for the root project: that is, if I run bower install from within this project then it will force the resolved version, but if I run it in a project for which angular-schema-form is a dependency, it is ignored.

Similarly, when there's a conflict in your dependencies (for example, if one package declares 1.2 and another 1.3) bower prompts the user to resolve the conflict by picking which one to use. Thus by declaring 1.3 in the package it just acts as a warning to those running on older versions, even though it will still run on them.

All that said, I really don't have any problem using >=1.2, so I'll switch it back :)

davidlgj added a commit that referenced this pull request Oct 3, 2014
@davidlgj davidlgj merged commit e1a663a into json-schema-form:development Oct 3, 2014
@davidlgj
Copy link
Contributor

davidlgj commented Oct 3, 2014

Alright I merged it. Thank you for looking into this, I want bower support but not really using it myself I guess it's easy to introduce errors :-)

@mike-marcacci
Copy link
Contributor Author

Thanks so much @davidlgj, and no worries! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants