Skip to content

In expansion, allow a language map to have a null value #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2017

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Apr 9, 2017

which is allowed in the syntax. Such values are ignored.

Fixes #375.

…llowed in the syntax. Such values are ignored.

Fixes #375.
@gkellogg gkellogg added the api label Apr 9, 2017
@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Apr 9, 2017
@gkellogg gkellogg self-assigned this Apr 9, 2017
@gkellogg
Copy link
Member Author

gkellogg commented Apr 9, 2017

@dlongley: note this does not address step 7.4.7, as you suggested. It didn't seem necessary given the syntax requirement. See my comment in the issue.

@@ -1485,14 +1485,16 @@
<li>For each <em>item</em> in <em>language value</em>:
<ol class="algorithm">
<li><em>item</em> must be a <a>string</a>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can nix the comma at the end of the line here

Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment in there about removing an erroneous comma, otherwise LGTM.

@gkellogg gkellogg merged commit 39d069d into master Apr 10, 2017
@gkellogg gkellogg deleted the issue-375-null-language-map-value branch April 10, 2017 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants