Skip to content

Add CSP: upgrade-insecure-requests #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

BigBlueHat
Copy link
Member

Fixes the Mixed Content mess...for real.

I have this in place on the LevelGraph Playground and it works.

Cheers!
🎩

Fixes the Mixed Content mess...for real.
@gkellogg gkellogg merged commit 55e2525 into json-ld:master Mar 30, 2017
@gkellogg
Copy link
Member

Looks like this is causing the playground to not load, I'm going to back it out.

@davidlehn
Copy link
Member

http://caniuse.com/#search=upgrade-insecure-requests
This is not universally supported. I just tested in Edge by adding "http://schema.org" to the @context in that above link. It output a console "Access is deined." error. So some other solution is still needed if the desire is to just blindly switch protocols.

I think sites should warn users if they are doing this. Or maybe make it an option somehow. In practice it's probably true that most sites serve the same data on https and http. But that's not a requirement. It's also very possible that a server for a http URL might not support https. What happens in that case?

gkellogg added a commit that referenced this pull request Mar 30, 2017
This caused the playground to hang.
@gkellogg
Copy link
Member

Site doesn't run HTTPS quite yet, once it does, we can re-apply this.

cc/ @davidlehn

@BigBlueHat
Copy link
Member Author

Yeah. Sorry about this mess. It's not of my making of course. 😉 But obviously these attempts to fix the mess the browser are making by "aggressively deprecating HTTP" with these sort of sanctioned "hacks" aren't really going to solve for all the scenarios possible--especially in a playground such as this.

I'd also forgotten (apologies) that the json-ld.org site wasn't using HTTPS yet--whereas the LevelGraph Playground is because of *.github.io URLs all being HTTPS now.

Anyhow. Apologies for yet-more-mess trying to solve for these scenarios.

I do hope some leadership in the Linked Data space surfaces that addresses this "rename all the things" situation...

Sorry again,
🎩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants