-
Notifications
You must be signed in to change notification settings - Fork 158
Issue 415 scope on type #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ely during expansion, and compacted appropriately during compaction. Add tests verifying this behavior.
…ype` or in a type map. Fixes #415.
@@ -194,7 +194,7 @@ | |||
<dd>An unordered labeled directed graph, where <tref title="node">nodes</tref> are | |||
<tref title="IRI">IRIs</tref> or <tref title="Blank Node">Blank Nodes</tref>, or other values. | |||
A <tref>JSON-LD graph</tref> is a generalized representation of a | |||
<cite><a href="http://www.w3.org/TR/rdf11-concepts/#dfn-rdf-graph">RDF graph</a></cite> | |||
<cite><a href="http://www.w3.org/TR/RDF11-CONCEPTS/#dfn-rdf-graph">RDF graph</a></cite> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL redirects to the lower-case version, why did you change it?
Because we use upper case within However, I didn't intend to update the json-ld-connect spec, so I'll reverse that change. |
…on, and json-ld-rdf.
Who is we? ReSpec? That sounds like a bug to me. |
We is, we the editors of JSON-LD. For example, we use It doesn't really matter to me, but to use The fact that ReSpec is case-sensitive seems like a design decision, which I wasn't interested in pursuing. Feel free to take it up on spec-prod. |
@lanthaler do you have an substantive feedback on this PR? |
No, and unfortunately I don't have the time to properly review it. As discussed elsewhere I'm concerned about the complexity of JSON-LD but see the value of this feature. So I'm fine with this being merged. |
This commit adds scoping based on
@type
for expansion and compaction. Also ensure that types used in type maps have any associated local context applied to their values.Also, corrects some minor errors in id and type maps where values were not appropriately expanded ore compacted.
Fixes #415.