Skip to content

Issue 415 scope on type #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 15, 2017
Merged

Issue 415 scope on type #462

merged 5 commits into from
Feb 15, 2017

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Feb 4, 2017

This commit adds scoping based on @type for expansion and compaction. Also ensure that types used in type maps have any associated local context applied to their values.

Also, corrects some minor errors in id and type maps where values were not appropriately expanded ore compacted.

Fixes #415.

…ely during expansion, and compacted appropriately during compaction. Add tests verifying this behavior.
@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Feb 4, 2017
@gkellogg gkellogg self-assigned this Feb 4, 2017
@@ -194,7 +194,7 @@
<dd>An unordered labeled directed graph, where <tref title="node">nodes</tref> are
<tref title="IRI">IRIs</tref> or <tref title="Blank Node">Blank Nodes</tref>, or other values.
A <tref>JSON-LD graph</tref> is a generalized representation of a
<cite><a href="http://www.w3.org/TR/rdf11-concepts/#dfn-rdf-graph">RDF graph</a></cite>
<cite><a href="http://www.w3.org/TR/RDF11-CONCEPTS/#dfn-rdf-graph">RDF graph</a></cite>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL redirects to the lower-case version, why did you change it?

@gkellogg
Copy link
Member Author

gkellogg commented Feb 8, 2017

Because we use upper case within [[]], it was creating two references, one normative and one informative. When I discussed this with Melvin, he felt this was appropriate behavior. To get back to a single entry in the reference section, it was necessary to unify the use within [[]] and @data-cite.

However, I didn't intend to update the json-ld-connect spec, so I'll reverse that change.

@lanthaler
Copy link
Member

Because we use upper case within [[]], it was creating two references, one normative and one informative. When I discussed this with Melvin, he felt this was appropriate behavior.

Who is we? ReSpec? That sounds like a bug to me.

@gkellogg
Copy link
Member Author

gkellogg commented Feb 9, 2017

We is, we the editors of JSON-LD. For example, we use [[RDF11-CONCEPTS]], instead of [[rdf11-concepts]], and so-forth. We could, of course, change to use lower-case references uniformly.

It doesn't really matter to me, but to use @data-cite, we need to be consistent, and this seems like a pretty nice feature of ReSpec to me.

The fact that ReSpec is case-sensitive seems like a design decision, which I wasn't interested in pursuing. Feel free to take it up on spec-prod.

@gkellogg
Copy link
Member Author

gkellogg commented Feb 9, 2017

@lanthaler do you have an substantive feedback on this PR?

@lanthaler
Copy link
Member

No, and unfortunately I don't have the time to properly review it. As discussed elsewhere I'm concerned about the complexity of JSON-LD but see the value of this feature. So I'm fine with this being merged.

@gkellogg gkellogg merged commit 297d6d7 into master Feb 15, 2017
@gkellogg gkellogg deleted the issue-415-scope-on-type branch February 15, 2017 19:41
@gkellogg gkellogg modified the milestone: JSON-LD 1.1 Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants