Skip to content

Fixes auto-discovery when using multiple assemblies #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2021

Conversation

bart-degreed
Copy link
Contributor

Fixes auto-discovery when resources, DbContexts and injectables are spread over different assemblies.

Fixes #995.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #997 (35bd5a6) into master (d033166) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #997   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         281      281           
  Lines        7429     7433    +4     
=======================================
+ Hits         6780     6784    +4     
  Misses        649      649           
Impacted Files Coverage Δ
...e/Configuration/ResourceDescriptorAssemblyCache.cs 100.00% <100.00%> (ø)
...DotNetCore/Configuration/ServiceDiscoveryFacade.cs 97.29% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d033166...35bd5a6. Read the comment docs.

@bart-degreed bart-degreed requested a review from maurei May 12, 2021 10:05
@maurei maurei merged commit 6be4bae into master May 14, 2021
@maurei maurei deleted the fix-autodiscovery branch May 14, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Discovery does not discover injectables not co-located with resources
2 participants