Filters: allow has() with a condition #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @wayne-o because you asked about this in the Gitter chat some time ago. |
|
@maurei Reverted to Draft, because my code contains a TODO that I still need to investigate. |
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
+ Coverage 91.26% 91.30% +0.03%
==========================================
Files 281 281
Lines 7429 7463 +34
==========================================
+ Hits 6780 6814 +34
Misses 649 649
Continue to review full report at Codecov.
|
bart-degreed
force-pushed
the
has-with-condition
branch
from
97ca1cc to
05dc242
Compare
added 4 commits
May 3, 2021 09:51
…e has() function. Example: GET /blogs?filter=has(posts,not(equals(url,null)))
…parsers already constrained the input, so API users should not observe any effects of this change.
bart-degreed
force-pushed
the
has-with-condition
branch
from
05dc242 to
ad2625d
Compare
maurei
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for an optional condition in the
hasfunction within filter query strings.Also added EBNF grammar for filters to documentation and narrowed some types in the filter parse tree.
Closes #985.