Skip to content

Removed case-insensitive comparisons from DisableQueryStringAttribute #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Removed case-insensitive comparisons from DisableQueryStringAttribute #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Examples/JsonApiDotNetCoreExample/Services/SkipCacheQueryStringParameterReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class SkipCacheQueryStringParameterReader : IQueryStringParameterReader

public bool IsEnabled(DisableQueryStringAttribute disableQueryStringAttribute)
{
return !disableQueryStringAttribute.ParameterNames.Contains(_skipCacheParameterName.ToLowerInvariant());
return !disableQueryStringAttribute.ParameterNames.Contains(_skipCacheParameterName);
}

public bool CanRead(string parameterName)
Expand Down
6 changes: 3 additions & 3 deletions src/JsonApiDotNetCore/Controllers/Annotations/DisableQueryStringAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public DisableQueryStringAttribute(StandardQueryStringParameters parameters)
if (value != StandardQueryStringParameters.None && value != StandardQueryStringParameters.All &&
parameters.HasFlag(value))
{
parameterNames.Add(value.ToString().ToLowerInvariant());
parameterNames.Add(value.ToString());
}
}

Expand All @@ -51,12 +51,12 @@ public DisableQueryStringAttribute(string parameterNames)
{
if (parameterNames == null) throw new ArgumentNullException(nameof(parameterNames));

ParameterNames = parameterNames.Split(",").Select(x => x.Trim().ToLowerInvariant()).ToList();
ParameterNames = parameterNames.Split(",").ToList();
}

public bool ContainsParameter(StandardQueryStringParameters parameter)
{
var name = parameter.ToString().ToLowerInvariant();
var name = parameter.ToString();
return ParameterNames.Contains(name);
}
}
Expand Down