Skip to content

Break up AttrCapabilities.AllowChange #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Break up AttrCapabilities.AllowChange #826

merged 2 commits into from
Sep 17, 2020

Conversation

bart-degreed
Copy link
Contributor

Before, AttrCapabilities.AllowChange was used for both POST and PATCH requests (although documentation said it was only for PATCH).

This commit adds a new flag and changes the meaning of the old one:

  • AttrCapabilities.AllowCreate affects only POST
  • AttrCapabilities.AllowChange affects only PATCH

Fixes #801.

Before, `AttrCapabilities.AllowChange` was used for both POST and PATCH requests (although documentation said it was only for PATCH).

This commit adds a new flag and changes the meaning of the old one:
- AttrCapabilities.AllowCreate affects only POST
- AttrCapabilities.AllowChange affects only PATCH
@bart-degreed bart-degreed requested a review from maurei September 14, 2020 12:46
@bart-degreed bart-degreed requested a review from maurei September 17, 2020 08:35
@maurei maurei merged commit d93f021 into json-api-dotnet:master Sep 17, 2020
@bart-degreed bart-degreed deleted the allow-create branch September 17, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add AttrCapabilities.AllowCreate
2 participants