Skip to content

Fix: incorrect resource type comparison #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 15, 2020

Conversation

maurei
Copy link
Member

@maurei maurei commented Sep 9, 2020

Fixes #789

  • No longer relies on ActionDescriptor to get an expected type, but retrieves it from IJsonApiRequest instead

@maurei maurei requested a review from bart-degreed September 9, 2020 15:14
@maurei maurei marked this pull request as ready for review September 9, 2020 15:14
@maurei maurei marked this pull request as draft September 10, 2020 06:56
@maurei maurei force-pushed the fix/resourcetype-comparison-bug branch from 36ceb97 to 27f31be Compare September 10, 2020 11:01
@maurei maurei marked this pull request as ready for review September 10, 2020 11:11
@bart-degreed
Copy link
Contributor

@maurei Can you resolve merge conflicts?

Copy link
Contributor

@bart-degreed bart-degreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Looks great!

@maurei maurei requested a review from bart-degreed September 15, 2020 08:50
Copy link
Contributor

@bart-degreed bart-degreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, one more small change.

@maurei maurei requested a review from bart-degreed September 15, 2020 10:32
@bart-degreed bart-degreed merged commit b32e304 into master Sep 15, 2020
@bart-degreed bart-degreed deleted the fix/resourcetype-comparison-bug branch September 15, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Type match incorrect for PATCH requests
2 participants