Change tracking for patch updates, to improve json:api spec compliance #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added some calculated properties to the examples, in order to have tests for: - nothing outside the patch request changed (returns empty data) - `KebabCaseFormatterTests.KebabCaseFormatter_Update_IsUpdated` has no side effects in updating `KebabCasedModel` attributes - `ManyToManyTests.Can_Update_Many_To_Many` has no side effects in updating `Article` tags - `ManyToManyTests.Can_Update_Many_To_Many_With_Complete_Replacement` has no side effects in updating `Article` tags - `ManyToManyTests.Can_Update_Many_To_Many_With_Complete_Replacement_With_Overlap` has no side effects in updating `Article` tags - exposed attribute that was not in PATCH request changed (returns attributes) - `UpdatingDataTests.PatchResource_ModelWithEntityFrameworkInheritance_IsPatched` updates `User.Password` property, which updates exposed `LastPasswordChange` attribute - `UpdatingDataTests.Patch_Entity_With_HasMany_Does_Not_Include_Relationships` updates `Person.FirstName` property, which updates exposed `Initials` attribute - `TodoItemsControllerTests.Can_Patch_TodoItemWithNullable` does not update exposed `TodoItem.AlwaysChangingValue` attribute - exposed attribute that was in PATCH request changed (returns attributes) - `TodoItemsControllerTests.Can_Patch_TodoItem` updates `TodoItem.AlwaysChangingValue` attribute Also updated a few places where an empty list was allocated each time with a cached empty array instance.
maurei
reviewed
Apr 13, 2020
maurei
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some calculated properties to the examples, in order to have tests for:
KebabCaseFormatterTests.KebabCaseFormatter_Update_IsUpdatedhas no side effects in updatingKebabCasedModelattributesManyToManyTests.Can_Update_Many_To_Manyhas no side effects in updatingArticletagsManyToManyTests.Can_Update_Many_To_Many_With_Complete_Replacementhas no side effects in updatingArticletagsManyToManyTests.Can_Update_Many_To_Many_With_Complete_Replacement_With_Overlaphas no side effects in updatingArticletagsUpdatingDataTests.PatchResource_ModelWithEntityFrameworkInheritance_IsPatchedupdatesUser.Passwordproperty, which updates exposedLastPasswordChangeattributeUpdatingDataTests.Patch_Entity_With_HasMany_Does_Not_Include_RelationshipsupdatesPerson.FirstNameproperty, which updates exposedInitialsattributeTodoItemsControllerTests.Can_Patch_TodoItemWithNullabledoes not update exposedTodoItem.AlwaysChangingValueattributeTodoItemsControllerTests.Can_Patch_TodoItemupdatesTodoItem.AlwaysChangingValueattributeAlso updated a few places where an empty list was allocated each time with a cached empty array instance.
Fixes #577.