Skip to content

Fix for non-deterministic failing tests #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Fix for non-deterministic failing tests #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5739b94
Moved tests for `NoEntityFrameworkTests` into a different database, b…
Jan 22, 2020
d267ae1
Fixed another bug, where tests would sometimes fail
Feb 5, 2020
01b388f
Fixed invalid logging configuration
Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Examples/JsonApiDotNetCoreExample/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@
"Default": "Warning",
"System": "Warning",
"Microsoft": "Warning",
"LogLevel": {
"Microsoft.EntityFrameworkCore": "Debug"
}
"Microsoft.EntityFrameworkCore": "Debug"
}
}
}
12 changes: 0 additions & 12 deletions src/Examples/NoEntityFrameworkExample/Models/TodoItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,5 @@ public TodoItem()

[Attr]
public Guid GuidProperty { get; set; }

[Attr]
public DateTime CreatedDate { get; set; }

[Attr(isFilterable: false, isSortable: false)]
public DateTime? AchievedDate { get; set; }

[Attr]
public DateTime? UpdatedDate { get; set; }

[Attr]
public DateTimeOffset? OffsetDate { get; set; }
}
}
4 changes: 2 additions & 2 deletions src/Examples/NoEntityFrameworkExample/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
{
"Data": {
"DefaultConnection": "Host=localhost;Port=5432;Database=JsonApiDotNetCoreExample;User ID=postgres;Password=postgres"
"DefaultConnection": "Host=localhost;Port=5432;Database=JsonApiDotNetCoreNoEFCoreExample;User ID=postgres;Password=postgres"
},
"Logging": {
"IncludeScopes": false,
Expand Down
3 changes: 1 addition & 2 deletions test/JsonApiDotNetCoreExampleTests/JsonApiDotNetCoreExampleTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
</PropertyGroup>

<ItemGroup>
<None Update="xunit.runner.json;appsettings.json">
<None Update="xunit.runner.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="../../src/Examples/JsonApiDotNetCoreExample/JsonApiDotNetCoreExample.csproj" />
<ProjectReference Include="../../src/Examples/NoEntityFrameworkExample/NoEntityFrameworkExample.csproj" />
<ProjectReference Include="../UnitTests/UnitTests.csproj" />
</ItemGroup>

Expand Down
15 changes: 0 additions & 15 deletions test/JsonApiDotNetCoreExampleTests/appsettings.json
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions test/NoEntityFrameworkTests/NoEntityFrameworkTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>$(NetCoreAppVersion)</TargetFramework>
<PreserveCompilationContext>true</PreserveCompilationContext>
Expand All @@ -9,7 +9,7 @@
<ServerGarbageCollection>true</ServerGarbageCollection>
</PropertyGroup>
<ItemGroup>
<None Update="xunit.runner.json;appsettings.json">
<None Update="xunit.runner.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
Expand Down
15 changes: 0 additions & 15 deletions test/NoEntityFrameworkTests/appsettings.json
View file
Open in desktop

This file was deleted.