Skip to content

Attr property info #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2020
Merged

Attr property info #662

merged 2 commits into from
Jan 9, 2020

Conversation

bart-degreed
Copy link
Contributor

@bart-degreed bart-degreed commented Jan 6, 2020 •
edited
Loading

Closes #650

FEATURE

  • Made AttrAttribute.PropertyInfo public and removed AttrAttribute.InternalAttributeName.
  • Removed unused interface IRelationshipField.

@bart-degreed bart-degreed mentioned this pull request Jan 6, 2020
Closed
@bart-degreed
Copy link
Contributor Author

@maurei I was unable to run all tests locally, because I do not have pgsql installed. If they do not run automatically during PR build, someone should try them before merging this in.

maurei
maurei approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@maurei maurei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging to master the CI pipeline runs the tests in the cloud: they all pass. I replied to the testing issue in my reply to your message in our gitter channel

@maurei maurei merged commit 2b64e03 into json-api-dotnet:master Jan 9, 2020
@bart-degreed bart-degreed deleted the attr-property-info branch January 9, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurei maurei maurei approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: publicly expose AttrAttribute.PropertyInfo getter
2 participants
@bart-degreed @maurei