Feature/request meta #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t at JsonApiOutputFormatter removes logic from JsonApiOutputFormatter and into JsonApiWriter. this also reduces the large method parameter requirements throughout the affected classes
…root at JsonApiInputFormatter removes logic from the input formatter and into JsonApiReader. Significantly reduces coupling of concrete types.
This is not a significant breaking change, but does affect the serialization APIs which may be used by tests
jaredcnance
commented
Mar 17, 2017
| @@ -57,7 +57,7 @@ public RepositoryOverrideTests(DocsFixture<Startup, JsonDocWriter> fixture) | |||
| // act | |||
| var response = await client.SendAsync(request); | |||
| var responseBody = await response.Content.ReadAsStringAsync(); | |||
| var deserializedBody = JsonApiDeSerializer.DeserializeList<TodoItem>(responseBody, jsonApiContext, _fixture.GetService<AppDbContext>()); | |||
| var deserializedBody = _fixture.GetService<IJsonApiDeSerializer>().DeserializeList<TodoItem>(responseBody); | |||
|
|
|||
There was a problem hiding this comment.
The only "breaking" changes here are Serialization/DeSerialization APIs. I would consider this a breaking change because it may be used in tests. This is a much needed change that helps to de-couple concrete types.
I implemented it in this PR because allowing an IRequestMeta service to be injected and used by the DocumentBuilder would require an extra call to HttpContext.RequestServices.GetService<TService>().
These changes reduce the number of times we have to go back to the container. We now define 3 distinct composition roots from which all services resolve:
JsonApiInputFormatterJsonApiControllerJsonApiOutputFormatter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56