-
-
Notifications
You must be signed in to change notification settings - Fork 158
Hooks #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks #478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this work started. A few comments. I think the bulk of the work will be in writing and testing the expression trees.
…e method as we are no longer going to build expression trees manually
…, wired it up to many to many usecase
…action. Added foundation for reflective discovery of hook implementations in IImplementedResourceHooks<TEntity>
@wisepotato regarding your comment:
That's fine, but should be behind a feature flag in |
@jaredcnance not sure what that would mean exactly with respect to the updated proposal we put in the first post of this topic |
@maurei, what I think @jaredcnance wants to say is that the eventual implementation should implement it with the ability of filtering in DB allowed, for the GET Pipeline, as that is to be expected to be functional at some point, this to improve backward compatibility in the future. |
…raded for better quality of life
Dismissing as discussed in gitter channel
see comment below on usage guide
Also, removed some outdated comments/discussion to clear the clutter.