Skip to content

Hooks #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 185 commits into from
Jun 17, 2019
Merged

Hooks #478

merged 185 commits into from
Jun 17, 2019

Conversation

wisepotato
Copy link
Contributor

@wisepotato wisepotato commented Feb 20, 2019

see comment below on usage guide

Also, removed some outdated comments/discussion to clear the clutter.

Copy link
Contributor

@jaredcnance jaredcnance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this work started. A few comments. I think the bulk of the work will be in writing and testing the expression trees.

@wisepotato wisepotato changed the title feat(business-logic): added more integration with ResourceDefinition ResourceDefinition handling logic Mar 22, 2019
Harro van der Kroft and others added 6 commits March 22, 2019 17:51
@wisepotato wisepotato changed the title ResourceDefinition handling logic Hooks Apr 8, 2019
@jaredcnance
Copy link
Contributor

@wisepotato regarding your comment:

To reiterate this means we'll have to fetch the results fully and then filter in-memory @jaredcnance is that something you can live with for now?

That's fine, but should be behind a feature flag in JsonApiOptions.

@maurei
Copy link
Member

maurei commented Apr 14, 2019

@jaredcnance not sure what that would mean exactly with respect to the updated proposal we put in the first post of this topic

@wisepotato
Copy link
Contributor Author

@maurei, what I think @jaredcnance wants to say is that the eventual implementation should implement it with the ability of filtering in DB allowed, for the GET Pipeline, as that is to be expected to be functional at some point, this to improve backward compatibility in the future.

@maurei maurei dismissed milosloub’s stale review June 17, 2019 09:43

Dismissing as discussed in gitter channel

@maurei maurei merged commit ec4e76e into json-api-dotnet:master Jun 17, 2019
@maurei maurei deleted the feat/#477 branch June 17, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants