Skip to content

Initializing PageOffset to be 1 (instead of default 0) so that the 'n… #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

nwise
Copy link
Contributor

@nwise nwise commented Mar 23, 2018

…ext' pagination link is set properly when no 'page[number]' is passed in the query string.

Closes #242

BUG FIX

  • reproduce issue in tests
  • fix issue
  • bump package version

FEATURE

  • write tests that address the requirements outlined in the issue
  • fulfill the feature requirements
  • bump package version

…ext' pagination link is set properly when no 'page[number]' is passed in the query string.
@jaredcnance
Copy link
Contributor

Thanks! Will go out in the deployment this weekend.

@jaredcnance jaredcnance merged commit 521547b into json-api-dotnet:master Mar 23, 2018
jaredcnance added a commit that referenced this pull request Aug 12, 2018
Initializing PageOffset to be 1 (instead of default 0) so that the 'n…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

'page[number]' value for 'next' pagination link incorrectly set to 1 when only 'page[size]' is passed
2 participants