Feat/#211 #220
Merged
Feat/#211 #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright. I will try to fix those test failures. |
|
I added some unit tests and also took the liberty of simplifying the paging acceptance tests by reducing the amount of logic in the assert sections. |
jaredcnance
reviewed
Jan 10, 2018
| .ToListAsync()) | ||
| .OrderBy(t => t.Id) | ||
| .ToList(); | ||
| return await entities.PageForward(pageSize, pageNumber).ToListAsync(); |
There was a problem hiding this comment.
why are you calling the ToListAsync() extension method over your own this.ToListAsync(/*...*/) ?
There was a problem hiding this comment.
No particular reason. I thought, the extension methods are an implementation detail anyway. We can use the repo's own method if you like that better.
There was a problem hiding this comment.
That's fair, I suppose the query realization methods exposed here are really only required for the service layer's use. I'm fine with this.
jaredcnance
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
FEATURE