-
-
Notifications
You must be signed in to change notification settings - Fork 158
Code quality refresh #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Code quality refresh #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CA2254: Template should be a static expression - CA1848: use the LoggerMessage delegates
…ount() when available
9556b44
to
7061e4c
Compare
Suppressed in various files because the analyzer is buggy, inconsistent and inflexible.
…ull' check Applying the refactoring changes the order of execution
…lar expression implementation at compile time
- Logger category name can consist of whitespace - Assembly/type/member name can NOT consist of whitespace - JSON:API field name can NOT consist of whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh code analysis rulesets, to reduce noise in the IDE and enable various CA* rules.
Code coverage is slightly lower than before because:
IEnumerable<>
, whereas the underlying type is an array. If that ever changes, there's fallback code that copies the collection anyway. But it doesn't make sense to write tests for such fallbacks.QUALITY CHECKLIST