Skip to content

Document PR workflow #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Document PR workflow #1487

merged 1 commit into from
Mar 2, 2024

Conversation

bkoelman
Copy link
Member

This PR documents the responsibilities and mutual expectations for a smooth PR review workflow.

@bkoelman bkoelman marked this pull request as ready for review February 28, 2024 23:43
@bkoelman
Copy link
Member Author

bkoelman commented Feb 28, 2024

@verdie-g This is what worked well between Maurits and me. Would this work for you?

@bkoelman bkoelman force-pushed the clarify-pr-workflow branch from 5ce58b0 to 79e2f1e Compare February 28, 2024 23:47
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (7a64b9d) to head (79e2f1e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1487   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         344      344           
  Lines       11003    11003           
  Branches     1805     1805           
=======================================
  Hits         9985     9985           
  Misses        669      669           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman merged commit 72bd6f8 into master Mar 2, 2024
@bkoelman bkoelman deleted the clarify-pr-workflow branch March 2, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant