Skip to content

Merge master into openapi #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 27, 2023
Merged

Merge master into openapi #1433

merged 26 commits into from
Dec 27, 2023

Conversation

bkoelman
Copy link
Member

No description provided.

dependabot bot and others added 26 commits November 29, 2023 01:14
* Update Resharper to RC1
* Revert workaround
* Add directive to correct formatting style

* Promote Global:PropertyCanBeMadeInitOnly to warning, so it aligns with what Resharper shows in VS, and address new violations
Bumps jetbrains.resharper.globaltools from 2023.3.1 to 2023.3.2.

---
updated-dependencies:
- dependency-name: jetbrains.resharper.globaltools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ins.resharper.globaltools-2023.3.2

Bump jetbrains.resharper.globaltools from 2023.3.1 to 2023.3.2; fix new warnings
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [JetBrains/qodana-action](https://github.com/jetbrains/qodana-action) from 2023.2 to 2023.3.
- [Release notes](https://github.com/jetbrains/qodana-action/releases)
- [Commits](JetBrains/qodana-action@v2023.2...v2023.3)

---
updated-dependencies:
- dependency-name: JetBrains/qodana-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s considered an anti-pattern, leading to occasional compatibility issues. (#1431)

This unblocks use in [Aspire](https://learn.microsoft.com/en-us/dotnet/aspire/) (more specifically, its usage of `AddNpgsqlDataSource`, which throws an `ObjectDisposedException`) and fixes #1082.
@bkoelman bkoelman changed the base branch from master to openapi December 27, 2023 12:13
@bkoelman bkoelman force-pushed the merge-master-into-openapi branch from 7e999a3 to f1a5d0e Compare December 27, 2023 12:14
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (354370b) 91.12% compared to head (f1a5d0e) 91.09%.

Files Patch % Lines
...tNetCore.OpenApi.Client/Exceptions/ApiException.cs 75.00% 0 Missing and 1 partial ⚠️
...NetCore.OpenApi.Client/UnreachableCodeException.cs 0.00% 1 Missing ⚠️
...nApiDotNetCore.OpenApi/UnreachableCodeException.cs 0.00% 1 Missing ⚠️
...NetCore/Configuration/JsonApiApplicationBuilder.cs 96.87% 0 Missing and 1 partial ⚠️
.../JsonApiDotNetCore/Errors/InvalidQueryException.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1433      +/-   ##
===========================================
- Coverage    91.12%   91.09%   -0.03%     
===========================================
  Files          382      384       +2     
  Lines        12426    12357      -69     
  Branches      1986     1987       +1     
===========================================
- Hits         11323    11257      -66     
+ Misses         714      710       -4     
- Partials       389      390       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review December 27, 2023 12:45
@bkoelman bkoelman merged commit fcdb639 into openapi Dec 27, 2023
@bkoelman bkoelman deleted the merge-master-into-openapi branch December 27, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant