Skip to content

Update Resharper to RC1 #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Update Resharper to RC1 #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e4fee
Update Resharper to RC1
bkoelman Nov 30, 2023
906e3d2
Revert workaround
bkoelman Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"jetbrains.resharper.globaltools": {
"version": "2023.3.0-eap08",
"version": "2023.3.0-rc01",
"commands": [
"jb"
]
Expand Down
3 changes: 0 additions & 3 deletions test/JsonApiDotNetCoreTests/UnitTests/Configuration/DependencyContainerRegistrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
using TestBuildingBlocks;
using Xunit;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

namespace JsonApiDotNetCoreTests.UnitTests.Configuration;

public sealed class DependencyContainerRegistrationTests
Expand Down
3 changes: 0 additions & 3 deletions test/JsonApiDotNetCoreTests/UnitTests/FieldChains/FieldChainPatternInheritanceMatchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
using Xunit;
using Xunit.Abstractions;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

// ReSharper disable InconsistentNaming
#pragma warning disable AV1706 // Identifier contains an abbreviation or is too short

Expand Down
3 changes: 0 additions & 3 deletions test/JsonApiDotNetCoreTests/UnitTests/FieldChains/FieldChainPatternMatchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
using Xunit;
using Xunit.Abstractions;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

// ReSharper disable InconsistentNaming
#pragma warning disable AV1706 // Identifier contains an abbreviation or is too short

Expand Down
3 changes: 0 additions & 3 deletions test/JsonApiDotNetCoreTests/UnitTests/Middleware/JsonApiMiddlewareTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
using TestBuildingBlocks;
using Xunit;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

#pragma warning disable AV1561 // Signature contains too many parameters

namespace JsonApiDotNetCoreTests.UnitTests.Middleware;
Expand Down
3 changes: 0 additions & 3 deletions test/JsonApiDotNetCoreTests/UnitTests/ModelStateValidation/ModelStateValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
using TestBuildingBlocks;
using Xunit;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

namespace JsonApiDotNetCoreTests.UnitTests.ModelStateValidation;

public sealed class ModelStateValidationTests
Expand Down
3 changes: 0 additions & 3 deletions ...onApiDotNetCoreTests/UnitTests/ResourceDefinitions/CreateSortExpressionFromLambdaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
using TestBuildingBlocks;
using Xunit;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

namespace JsonApiDotNetCoreTests.UnitTests.ResourceDefinitions;

public sealed class CreateSortExpressionFromLambdaTests
Expand Down
3 changes: 0 additions & 3 deletions test/JsonApiDotNetCoreTests/UnitTests/ResourceGraph/ResourceGraphBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
using TestBuildingBlocks;
using Xunit;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

namespace JsonApiDotNetCoreTests.UnitTests.ResourceGraph;

public sealed class ResourceGraphBuilderTests
Expand Down
3 changes: 0 additions & 3 deletions test/JsonApiDotNetCoreTests/UnitTests/Serialization/Response/IncompleteResourceGraphTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
using Microsoft.Extensions.Logging.Abstractions;
using Xunit;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

namespace JsonApiDotNetCoreTests.UnitTests.Serialization.Response;

public sealed class IncompleteResourceGraphTests
Expand Down
3 changes: 0 additions & 3 deletions test/NoEntityFrameworkTests/NullSafeExpressionRewriterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
using NoEntityFrameworkExample;
using Xunit;

// Workaround for Resharper bug at https://youtrack.jetbrains.com/issue/RSRP-494909/Breaking-UsedImplicitly-and-PublicAPI-on-types-no-longer-respected.
// ReSharper disable PropertyCanBeMadeInitOnly.Local

namespace NoEntityFrameworkTests;

public sealed class NullSafeExpressionRewriterTests
Expand Down