Skip to content

Merge master v5.1.2 into openapi #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Feb 7, 2023
Merged

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Feb 7, 2023

I didn't encounter any merge conflicts worth mentioning.

QUALITY CHECKLIST

  • N/A: Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

bkoelman and others added 30 commits December 21, 2022 11:33
…n-any-function

Allow at least one constant instead of two in any() filter function
Reduce the number of concurrent testruns in cibuild
… would only kick in for required attributes, which is incorrect. We didn't have a test for an optional property containing a range validation, where the property default value is not in the required range. In that case, using such a resource as non-toplevel (for example: update relationship) would incorrectly produce a validation error.
Co-authored-by: Maurits Moeys <maurits.moeys@gmail.com>
Package updates; run tests against EF Core 7
Fixed: fail on non-leading whitespace in field chains
…on-non-required

Fixed: ModelState validation failed when [Range] does not include property default value
Documentation: FAQ and Common Pitfalls
@bkoelman bkoelman changed the base branch from master to openapi February 7, 2023 10:34
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1256 (3220fc8) into openapi (935fa2b) will increase coverage by 0.05%.
The diff coverage is 92.30%.

❗ Current head 3220fc8 differs from pull request most recent head 8d50846. Consider uploading reports for the commit 8d50846 to get more accurate results

@@             Coverage Diff             @@
##           openapi    #1256      +/-   ##
===========================================
+ Coverage    92.29%   92.34%   +0.05%     
===========================================
  Files          304      304              
  Lines         8859     8875      +16     
===========================================
+ Hits          8176     8196      +20     
+ Misses         683      679       -4     
Impacted Files Coverage Δ
...c/JsonApiDotNetCore/Configuration/ResourceGraph.cs 71.66% <0.00%> (-1.22%) ⬇️
...otNetCore/Queries/Internal/Parsing/FilterParser.cs 98.35% <ø> (-0.03%) ⬇️
src/Examples/NoEntityFrameworkExample/Program.cs 100.00% <100.00%> (ø)
...tations/Resources/Internal/RuntimeTypeConverter.cs 100.00% <100.00%> (+10.81%) ⬆️
...Core/Configuration/JsonApiModelMetadataProvider.cs 66.66% <100.00%> (-3.34%) ⬇️
...otNetCore/Configuration/JsonApiValidationFilter.cs 95.65% <100.00%> (ø)
...ore/Controllers/BaseJsonApiOperationsController.cs 100.00% <100.00%> (ø)
...etCore/Errors/UnsuccessfulActionResultException.cs 96.00% <100.00%> (+1.00%) ⬆️
...iDotNetCore/Middleware/JsonApiRoutingConvention.cs 92.75% <100.00%> (+0.69%) ⬆️
...ApiDotNetCore/Queries/Expressions/AnyExpression.cs 73.33% <100.00%> (+1.45%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman marked this pull request as ready for review February 7, 2023 11:49
@bkoelman bkoelman merged commit d82c754 into openapi Feb 7, 2023
@bkoelman bkoelman deleted the merge-master-v5.1.2-into-openapi branch February 7, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants