-
-
Notifications
You must be signed in to change notification settings - Fork 158
Merge master (v5.0.3) into openapi branch #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needs the Issue26779 EF Core back-compat switch. The switch is unavailable in EF 7, so this change unblocks us from upgrade.
… captured variables, potentially resulting in unintended allocations
… from producing diagnostics
…der (added in .NET 6). Also makes the model a bit more correct, as "ref" elements (used in atomic:operations) cannot occur in "data".
Minor serialization tweaks
Enable running code cleanup locally only on files changed since the specified branch
Remove dependency on EF Core "Issue26779" AppContext switch
Source generator tweaks
Package updates
Codecov Report
@@ Coverage Diff @@
## openapi #1186 +/- ##
========================================
Coverage 92.24% 92.24%
========================================
Files 302 303 +1
Lines 8768 8774 +6
========================================
+ Hits 8088 8094 +6
Misses 680 680
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4 tasks
maurei
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the merge itself, the last two commits are manual additions worth reviewing:
swagger.json
files:"minLength": 1
is being added, likely related to requiredness/nullability; I haven't investigated this furtherPlease merge this PR as a merge commit, so we can keep syncing up with
master
.