Merge master into openapi (retry) #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
December 1, 2021 11:36
* Removed Interface target from custom attributes, because it does not work (see https://stackoverflow.com/questions/540749/can-a-c-sharp-class-inherit-attributes-from-its-interface). Fixed detection of attribute usage on base classes. * Auto-generation of JSON:API controllers (using source generators) * Updated integration tests to use auto-generated controllers * Fixed: throw at startup when multiple controllers are registered for the same resource type * Addressed cleanupcode/inspectcode issues * Add dependency from JsonApiDotNetCore to SourceGenerators, so it gets pulled in via NuGet * Added unit tests for controller source generator * Update ROADMAP.md * Updated documentation * Produce NuGet package in cibuild This lets each project opt-in for producing a NuGet package, instead of listing them globally * Addressed review feedback
* Update to .NET 6 with EF Core 6 * Adapt to changes in nullability annotations * Adapt for breaking changes in PostgreSQL provider for EF Core 6 * Cleanup tests for handling special characters * Removed workaround for dotnet/efcore#21026 * Removed workaround for dotnet/aspnetcore#33394 * Removed workaround for dotnet/aspnetcore#32097 * Removed workaround for dotnet/efcore#21234 * Updated to latest Resharper version and removed workarounds for earlier versions * Applied new Resharper suggestions * Package updates * Renamed MSBuild variables * Inlined MSBuild variables that are used only once * Removed .BeCloseTo, now that fakers truncate time to whole milliseconds. Removed runtime casts, because the JSON deserializer now creates the correct types (based on the resource graph). * Narrow service scope lifetime * Enable registered services to dispose asynchronously, where possible * Workaround for bug in cleanupcode * Fixed detection of implicit many-to-many join entity in EF Core 6 * Activate implicit usings * Switched to file-scoped namespaces * Reformat solution * Added [NoResource] to suppress startup warning * Use Minimal Hosting APIs * Removed duplicate code * Corrected terminology for generic type usage * Fixed warning: Type 'KnownResource' does not contain any attributes * Updated roadmap and version table * Fixed: Override IIdentifiable.Id with custom capabilities no longer worked * Review feedback
* Moved resource-related attributes and (I)Identifiable to separate package * Fixed broken links in doc-comments * Update ROADMAP.md
Codecov Report
@@ Coverage Diff @@
## openapi #1130 +/- ##
==========================================
Coverage ? 89.43%
==========================================
Files ? 301
Lines ? 8263
Branches ? 0
==========================================
Hits ? 7390
Misses ? 873
Partials ? 0 Continue to review full report at Codecov.
|
bart-degreed
force-pushed
the
merge-master-into-openapi-retry
branch
from
c7b5b60 to
72fb125
Compare
maurei
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master into openapi (retry)
Green build (no inspectcode/cleanupcode) at https://ci.appveyor.com/project/json-api-dotnet/jsonapidotnetcore/builds/41882038.