Resource Graph validations #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
force-pushed
the
graph-validations
branch
from
b982b39 to
160030a
Compare
added 3 commits
November 6, 2021 00:12
…, but uses a resource type that is not registered in the resource graph
bart-degreed
force-pushed
the
graph-validations
branch
from
160030a to
22a0a09
Compare
Codecov Report
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
+ Coverage 88.59% 88.60% +0.01%
==========================================
Files 255 255
Lines 7127 7160 +33
==========================================
+ Hits 6314 6344 +30
- Misses 813 816 +3
Continue to review full report at Codecov.
|
maurei
approved these changes
Nov 8, 2021
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* Added extra validations of the resource graph and unified unit tests * Fail at startup on controller that derives from BaseJsonApiController, but uses a resource type that is not registered in the resource graph * Check off roadmap entry
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* Added extra validations of the resource graph and unified unit tests * Fail at startup on controller that derives from BaseJsonApiController, but uses a resource type that is not registered in the resource graph * Check off roadmap entry
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* Added extra validations of the resource graph and unified unit tests * Fail at startup on controller that derives from BaseJsonApiController, but uses a resource type that is not registered in the resource graph * Check off roadmap entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fails at startup with
InvalidConfigurationException:IIdentifiable, but notIIdentifiable<TId>services.AddResourceService/AddResourceRepository/AddResourceDefinitionis called with a type that does not implement any of the JsonApiDotNetCore interfacesThe following logs a warning at startup:
IIdentifiableis skipped during discovery or while adding fromDbContext.Fixes #170.
QUALITY CHECKLIST