Question: GetDefaultSortOrder not firing

[fdlane]

Description

In my ResourceDefinition I have two overrides, one for GetQueryFilters and one for GetDefaultSortOrder. For some reason, only the GetQueryFilter override fires.

My Postman request does not include any sort params.

Any ideas what I have done wrong here?

...

  public class ClientResource : ResourceDefinition<Client>
    {
      public ClientResource(IResourceGraph resourceGraph) : base(resourceGraph) { }
      public override PropertySortOrder GetDefaultSortOrder() => new PropertySortOrder
      {
        (t => t.DisplayName, SortDirection.Ascending)
      };
      public override QueryFilters GetQueryFilters() => new QueryFilters
      {
        {
        "search",
        (items, filter) => items.Where(i => i.DisplayName.Contains(filter.Value))
        }
      };
    }

Environment

• JsonApiDotNetCore Version: v4.0.0-alpha5
• Other Relevant Package Versions: core 3.1

[bart-degreed]

Hi @fdlane, thanks for asking. I don't think you did anything wrong, this looks like a bug.

The _queries field in SortService is initialized with an empty list here, so the null check here never succeeds, resulting in the if statement never being entered and thus the callback never getting fired.

[fdlane]

Thanks for the fast response.

Change to...?

     if (_queries == null ||  _queries.Count == 0)

[bart-degreed]

I would only check for empty, because the field can never be null.

[bart-degreed]

But we should have a test that covers this, too.