Posting JSONAPI data not binding

[wayne-o]

When I have the following classes:

public class ApplicationUserViewModel : Identifiable<string>
    {
        public ApplicationUserViewModel()
        {
            Id = Guid.NewGuid().ToString();
            Roles = new List<ApplicationRoleViewModel>();
        }

        [NotMapped]
        public string StringId { get => Id; set => Id = value; }

        [Attr("username")] public string UserName { get; set; }
        [Attr("email")] public string Email { get; set; }

        [HasMany("roles")]
        public List<ApplicationRoleViewModel> Roles
        {
            get;
            set;
        }
    }

public class ApplicationRoleViewModel : Identifiable<string>
    {
        public ApplicationRoleViewModel()
        {
            Users = new List<ApplicationUserViewModel>();
            Id = Guid.NewGuid().ToString();
        }

        [NotMapped]
        public string StringId { get => Id; set => Id = value; }

        [Attr("name")]
        public string Name { get; set; }

        [HasMany("users")]
        public List<ApplicationUserViewModel> Users
        {
            get;
            set;
        }
    }

And I post the following JSON

{
  "data": {
    "id": "461a2700-114b-4667-bacf-e4425d52354f",
    "attributes": {
      "email": "123@123.com"
    },
    "relationships": {
      "roles": {
        "data": [
          {
            "type": "roles",
            "id": "67fd9442-9d8c-45de-bf42-4af8be9a8d40"
          }
        ]
      }
    },
    "type": "users"
  }
}

It doesn't deserialize properly and the model passed into the controller has empty properties.

Is there anything glaringly wrong here?

[wayne-o]

Ok so digging into this, I am seeing the following output:

 An error occurred while de-serializing the payload
JsonApiDotNetCore.Internal.JsonApiException: Failed to deserialize request body ---> System.ArgumentException: DbSet of type XXX.Api.Models.ApplicationRoleViewModel not found on the DbContext
Parameter name: T

I am not using EF for this model - is there anyway to stop it trying to do this?

[jaredcnance]

Have you named your resource on the DbContext?

[Resource("roles")]

Checkout the last section here: https://json-api-dotnet.github.io/#/context-graph

But it looks like you're using a view model that probably isn't represented on the DbContext. If that's the case you have to manually register it (see the same documentation page). Eventually, we'll try autodiscovery but for now it has to be manually registered.

[wayne-o]

Yeah - but i don't want to use EF here - is there a way around this?

[wayne-o]

I have done this in startup to tell the framework about my non-ef types:

builder.AddResource<MyModel>("my-models");

[wayne-o]

I think the problem is that it drops into GenericProcessor.SetRelationships where it can only use DbContext to load the relations data.

[wayne-o]

I'm guessing that in the case of not using EF we would want to just pass forward what we have instead of trying to load them?

[wayne-o]

Or would I have to register my own IGenericProcessor - sorry this is getting noisy now :p

[jaredcnance]

Looks like you've stumbled onto a path that was written when I assumed everything was going to be EF. This is a "bug" and does not follow the current design pattern (all EF specific interfaces should be isolated to the repository layer). For now, you would have to inject your own GenericProcessorFactory that provides a different IGenericProcessor implementation based on the related type:
https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/src/JsonApiDotNetCore/Internal/Generics/GenericProcessorFactory.cs

The GenericProcessor deviates a bit from the normal DI based service injection because the relationship types are not known until after deserialization (after the composition root has been called).

Let me know if you run into any issues here. I'll be working on an official solution. The serialization layer should not be responsible for making calls to the database.

[wayne-o]

Yeah pretty much what I thought, all working now - good stuff :) cheers mate

On Wed, 28 Feb 2018 at 11:08, Jared Nance ***@***.***> wrote: Looks like you've stumbled onto a path that was written when I assumed everything was going to be EF. This is a "bug" and does not follow the current design pattern (all EF specific interfaces should be isolated to the repository layer). For now, you would have to inject your own GenericProcessorFactory that provides a different IGenericProcessor implementation based on the related type: https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/src/JsonApiDotNetCore/Internal/Generics/GenericProcessorFactory.cs The GenericProcessor deviates a bit from the normal DI based service injection because the relationship types are not known until after deserialization (after the composition root has been called). Let me know if you run into any issues here. I'll be working on an official solution. The serialization layer should not be responsible for making calls to the database. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#237 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAK3jE_cN8tytbxwoIaHSQeopuZOHSGAks5tZTOfgaJpZM4SWYH9> .

-- *--------------------* *w://* *t: 07508 215 459* *--------------------*

[wayne-o]

I think this has been fixed with the new IGenericProcessorFactory . - is that correct?

[wayne-o]

OK so I removed my IGenericProcessorFactory from the IOC and thought the framework would resolve my services now but I am getting this on startup:

Application startup exception: System.MissingMethodException: Method not found: 'Void JsonApiDotNetCore.Models.AttrAttribute..ctor(System.String, Boolean)'.

[jaredcnance]

I haven't done any additional work that would solve this issue yet. However, this is a major item for me and I'd like to get it in the next release. I still need to do some design around this. It may not be easy to develop a fix in a non-breaking way.

Regarding your exception, that occurs at runtime? Can you provide the stack trace?