Inconsistent casing for sort and filter queries

[shuebner]

I noticed that in a query, for the sort criteria casing does not matter while for the filter criteria the exact name is needed in the URL.
E. g. [Attr("fileName")] can be used for sorting with ?sort=filename, but can only be used for filtering with ?filter[entity]=fileName while ?filter[entity]=filename does not work.

Is that on purpose?

[jaredcnance]

It's not intentional and is an artifact from a prior approach that apparently didn't get cleaned up properly in QueryParser. It does a ToProperCase on the request parameter and then tries to match on the actual class property instead of doing an OrdinalIgnoreCase string comparison on the attribute definition.

Sorry I'm on mobile and fat fingered the close button.

Feel free to open a PR or I will come back to it tonight.

I think we should get this and #210 out in the next release. I'm not sure about #211 yet.

[shuebner]

That last comment got cut apparently.
What is the correct approach? Ignore the casing?

So, are you fixing this or should I prepare a PR?

[jaredcnance]

☝️

[shuebner]

I won't be able to make PR until next week.