AV1210: Do not catch-all

Author: Bart Koelman

src/JsonApiDotNetCore/AtomicOperations/OperationsProcessor.cs

@@ -84,7 +84,9 @@ public virtual async Task<IList<OperationContainer>> ProcessAsync(IList<Operatio
 
                 throw;
             }
+#pragma warning disable AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             catch (Exception exception)
+#pragma warning restore AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             {
                 throw new JsonApiException(new Error(HttpStatusCode.InternalServerError)
                 {

src/JsonApiDotNetCore/Resources/ResourceFactory.cs

@@ -44,7 +44,9 @@ private static IIdentifiable InnerCreateInstance(Type type, IServiceProvider ser
                     ? (IIdentifiable)Activator.CreateInstance(type)
                     : (IIdentifiable)ActivatorUtilities.CreateInstance(serviceProvider, type);
             }
+#pragma warning disable AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             catch (Exception exception)
+#pragma warning restore AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             {
                 throw new InvalidOperationException(
                     hasSingleConstructorWithoutParameters
@@ -77,7 +79,9 @@ public NewExpression CreateNewExpression(Type resourceType)
 
                     constructorArguments.Add(argumentExpression);
                 }
+#pragma warning disable AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
                 catch (Exception exception)
+#pragma warning restore AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
                 {
                     throw new InvalidOperationException(
                         $"Failed to create an instance of '{resourceType.FullName}': Parameter '{constructorParameter.Name}' could not be resolved.",

src/JsonApiDotNetCore/Serialization/JsonApiReader.cs

@@ -64,7 +64,9 @@ public async Task<InputFormatterResult> ReadAsync(InputFormatterContext context)
                 {
                     throw ToInvalidRequestBodyException(exception, body);
                 }
+#pragma warning disable AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
                 catch (Exception exception)
+#pragma warning restore AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
                 {
                     throw new InvalidRequestBodyException(null, null, body, exception);
                 }

src/JsonApiDotNetCore/Serialization/JsonApiWriter.cs

@@ -53,7 +53,9 @@ public async Task WriteAsync(OutputFormatterWriteContext context)
             {
                 responseContent = SerializeResponse(context.Object, (HttpStatusCode)response.StatusCode);
             }
+#pragma warning disable AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             catch (Exception exception)
+#pragma warning restore AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             {
                 ErrorDocument errorDocument = _exceptionHandler.HandleException(exception);
                 responseContent = _serializer.Serialize(errorDocument);

src/JsonApiDotNetCore/TypeHelper.cs

@@ -334,7 +334,9 @@ public static object CreateInstance(Type type)
             {
                 return Activator.CreateInstance(type);
             }
+#pragma warning disable AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             catch (Exception exception)
+#pragma warning restore AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
             {
                 throw new InvalidOperationException($"Failed to create an instance of '{type.FullName}' using its default constructor.", exception);
             }

test/TestBuildingBlocks/HttpResponseMessageExtensions.cs

@@ -50,7 +50,9 @@ private static async Task<string> GetFormattedContentAsync(HttpResponseMessage r
                         return JsonConvert.DeserializeObject<JObject>(text).ToString();
                     }
                 }
+#pragma warning disable AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
                 catch
+#pragma warning restore AV1210 // Catch a specific exception instead of Exception, SystemException or ApplicationException
                 {
                     // ignored
                 }