AV1115: Member contains the word 'and', which suggests doing multiple things

Bart Koelman · Bart Koelman · commit af9206d4c254 · 2021-03-08T17:06:27.000+01:00
diff --git a/src/JsonApiDotNetCore/Hooks/Internal/Execution/HookExecutorHelper.cs b/src/JsonApiDotNetCore/Hooks/Internal/Execution/HookExecutorHelper.cs
@@ -94,7 +94,7 @@ public IEnumerable LoadDbValues(LeftType resourceTypeForRepository, IEnumerable
             LeftType idType = TypeHelper.GetIdType(resourceTypeForRepository);
 
             MethodInfo parameterizedGetWhere =
-                GetType().GetMethod(nameof(GetWhereAndInclude), BindingFlags.NonPublic | BindingFlags.Instance)!.MakeGenericMethod(resourceTypeForRepository,
+                GetType().GetMethod(nameof(GetWhereWithInclude), BindingFlags.NonPublic | BindingFlags.Instance)!.MakeGenericMethod(resourceTypeForRepository,
                     idType);
 
             IEnumerable<IIdentifiable> cast = ((IEnumerable<object>)resources).Cast<IIdentifiable>();
@@ -153,7 +153,7 @@ private IHooksDiscovery GetHookDiscovery(LeftType resourceType)
             return discovery;
         }
 
-        private IEnumerable<TResource> GetWhereAndInclude<TResource, TId>(IReadOnlyCollection<TId> ids, RelationshipAttribute[] relationshipsToNextLayer)
+        private IEnumerable<TResource> GetWhereWithInclude<TResource, TId>(IReadOnlyCollection<TId> ids, RelationshipAttribute[] relationshipsToNextLayer)
             where TResource : class, IIdentifiable<TId>
         {
             if (!ids.Any())
diff --git a/test/JsonApiDotNetCoreExampleTests/IntegrationTests/RequiredRelationships/Shipment.cs b/test/JsonApiDotNetCoreExampleTests/IntegrationTests/RequiredRelationships/Shipment.cs
@@ -3,6 +3,8 @@
 using JsonApiDotNetCore.Resources;
 using JsonApiDotNetCore.Resources.Annotations;
 
+#pragma warning disable AV1115 // Member or local function contains the word 'and', which suggests doing multiple things
+
 namespace JsonApiDotNetCoreExampleTests.IntegrationTests.RequiredRelationships
 {
     [UsedImplicitly(ImplicitUseTargetFlags.Members)]

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public IEnumerable LoadDbValues(LeftType resourceTypeForRepository, IEnumerable`
`94`	`94`	`LeftType idType = TypeHelper.GetIdType(resourceTypeForRepository);`
`95`	`95`
`96`	`96`	`MethodInfo parameterizedGetWhere =`
`97`		`- GetType().GetMethod(nameof(GetWhereAndInclude), BindingFlags.NonPublic \| BindingFlags.Instance)!.MakeGenericMethod(resourceTypeForRepository,`
	`97`	`+ GetType().GetMethod(nameof(GetWhereWithInclude), BindingFlags.NonPublic \| BindingFlags.Instance)!.MakeGenericMethod(resourceTypeForRepository,`
`98`	`98`	`idType);`
`99`	`99`
`100`	`100`	`IEnumerable<IIdentifiable> cast = ((IEnumerable<object>)resources).Cast<IIdentifiable>();`
`@@ -153,7 +153,7 @@ private IHooksDiscovery GetHookDiscovery(LeftType resourceType)`
`153`	`153`	`return discovery;`
`154`	`154`	`}`
`155`	`155`
`156`		`- private IEnumerable<TResource> GetWhereAndInclude<TResource, TId>(IReadOnlyCollection<TId> ids, RelationshipAttribute[] relationshipsToNextLayer)`
	`156`	`+ private IEnumerable<TResource> GetWhereWithInclude<TResource, TId>(IReadOnlyCollection<TId> ids, RelationshipAttribute[] relationshipsToNextLayer)`
`157`	`157`	`where TResource : class, IIdentifiable<TId>`
`158`	`158`	`{`
`159`	`159`	`if (!ids.Any())`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,8 @@`
`3`	`3`	`using JsonApiDotNetCore.Resources;`
`4`	`4`	`using JsonApiDotNetCore.Resources.Annotations;`
`5`	`5`
	`6`	`+#pragma warning disable AV1115 // Member or local function contains the word 'and', which suggests doing multiple things`
	`7`	`+`
`6`	`8`	`namespace JsonApiDotNetCoreExampleTests.IntegrationTests.RequiredRelationships`
`7`	`9`	`{`
`8`	`10`	`[UsedImplicitly(ImplicitUseTargetFlags.Members)]`