test: added missing implicit tests

Author: maurei

test/UnitTests/ResourceHooks/ResourceHookExecutor/BeforeDelete_WithDbValue_Tests.cs

@@ -9,7 +9,6 @@
 
 namespace UnitTests.ResourceHooks
 {
-
     public class BeforeDelete_WithDbValues_Tests : HooksTestsSetup
     {
         private readonly DbContextOptions<AppDbContext> options;
@@ -29,7 +28,6 @@ public BeforeDelete_WithDbValues_Tests()
                 context.Set<Person>().Add(person);
                 context.SaveChanges();
             });
-
         }
 
         [Fact]
@@ -53,9 +51,8 @@ public void BeforeDelete()
             VerifyNoOtherCalls(personResourceMock, todoResourceMock, passportResourceMock);
         }
 
-
         [Fact]
-        public void BeforeDelete_NoParentHook()
+        public void BeforeDelete_No_Parent_Hooks()
         {
             // arrange
             var personDiscovery = SetDiscoverableHooks<Person>(NoHooks, NoHooks);
@@ -74,6 +71,25 @@ public void BeforeDelete_NoParentHook()
             VerifyNoOtherCalls(personResourceMock, todoResourceMock, passportResourceMock);
         }
 
+        [Fact]
+        public void BeforeDelete_No_Children_Hooks()
+        {
+            // arrange
+            var personDiscovery = SetDiscoverableHooks<Person>(AllHooks, EnableDbValuesEverywhere);
+            var todoDiscovery = SetDiscoverableHooks<TodoItem>(NoHooks);
+            var passportDiscovery = SetDiscoverableHooks<Passport>(NoHooks);
+            (var contextMock, var hookExecutor, var personResourceMock, var todoResourceMock,
+                var passportResourceMock) = CreateTestObjects(personDiscovery, todoDiscovery, passportDiscovery, repoDbContextOptions: options);
+
+            var todoList = CreateTodoWithOwner();
+            // act
+            hookExecutor.BeforeDelete(new List<Person> { person }, ResourceAction.Delete);
+
+            // assert
+            personResourceMock.Verify(rd => rd.BeforeDelete(It.IsAny<IEnumerable<Person>>(), It.IsAny<ResourceAction>()), Times.Once());
+            VerifyNoOtherCalls(personResourceMock, todoResourceMock, passportResourceMock);
+        }
+
         private bool CheckImplicitTodos(IUpdatedRelationshipHelper<TodoItem> rh)
         {
             var todos = rh.GetEntitiesRelatedWith<Person>().ToList();
@@ -85,7 +101,6 @@ private bool CheckImplicitPassports(IUpdatedRelationshipHelper<Passport> rh)
             var passports = rh.GetEntitiesRelatedWith<Person>().Single().Value;
             return passports.Count == 1;
         }
-
     }
 }
 

test/UnitTests/ResourceHooks/ResourceHookExecutor/BeforeUpdate_WithDbValues_Tests.cs

@@ -48,6 +48,7 @@ public BeforeUpdate_WithDbValues_Tests()
         [Fact]
         public void BeforeUpdate()
         {
+            // arrange
             var todoDiscovery = SetDiscoverableHooks<TodoItem>(AllHooks, EnableDbValuesEverywhere);
             var personDiscovery = SetDiscoverableHooks<Person>(AllHooks, EnableDbValuesEverywhere);
             (var contextMock, var hookExecutor, var todoResourceMock,
@@ -63,56 +64,49 @@ public void BeforeUpdate()
                 It.IsAny<IUpdatedRelationshipHelper<Person>>(),
                 ResourceAction.Patch),
                 Times.Once());
-
             ownerResourceMock.Verify(rd => rd.BeforeImplicitUpdateRelationship(
                 It.Is<IUpdatedRelationshipHelper<Person>>(rh => PersonCheck(lastName + lastName, rh)),
                 ResourceAction.Patch),
                 Times.Once());
-
             todoResourceMock.Verify(rd => rd.BeforeImplicitUpdateRelationship(
                 It.Is<IUpdatedRelationshipHelper<TodoItem>>( rh => TodoCheck(rh, description + description)),
                 ResourceAction.Patch),
                 Times.Once());
-
             VerifyNoOtherCalls(todoResourceMock, ownerResourceMock);
         }
 
 
         [Fact]
-        public void BeforeUpdate_Deleting_Relationship() // TODO l=3 implicit needs to be tested here too
+        public void BeforeUpdate_Deleting_Relationship()
         {
+            // arrange
             var todoDiscovery = SetDiscoverableHooks<TodoItem>(AllHooks, EnableDbValuesEverywhere);
             var personDiscovery = SetDiscoverableHooks<Person>(AllHooks, EnableDbValuesEverywhere);
             (var contextMock, var hookExecutor, var todoResourceMock,
                 var ownerResourceMock) = CreateTestObjects(todoDiscovery, personDiscovery, repoDbContextOptions: options);
-
             var attr = ResourceGraph.Instance.GetContextEntity(typeof(TodoItem)).Relationships.Single(r => r.PublicRelationshipName == "one-to-one-person");
             contextMock.Setup(c => c.RelationshipsToUpdate).Returns(new Dictionary<RelationshipAttribute, object>() { { attr, new object() } });
 
             // act
             var todoList = new List<TodoItem>() { new TodoItem { Id = this.todoList[0].Id } };
             hookExecutor.BeforeUpdate(todoList, ResourceAction.Patch);
 
-
             // assert
             todoResourceMock.Verify(rd => rd.BeforeUpdate(It.Is<EntityDiff<TodoItem>>((diff) => TodoCheck(diff, description)), ResourceAction.Patch), Times.Once());
-
-
             ownerResourceMock.Verify(rd => rd.BeforeImplicitUpdateRelationship(
                 It.Is<IUpdatedRelationshipHelper<Person>>(rh => PersonCheck(lastName + lastName, rh)),
                 ResourceAction.Patch),
                 Times.Once());
-
             VerifyNoOtherCalls(todoResourceMock, ownerResourceMock);
         }
 
 
         [Fact]
         public void BeforeUpdate_Without_Parent_Hook_Implemented()
         {
+            // arrange
             var todoDiscovery = SetDiscoverableHooks<TodoItem>(NoHooks);
             var personDiscovery = SetDiscoverableHooks<Person>(AllHooks, EnableDbValuesEverywhere);
-
             (var contextMock, var hookExecutor, var todoResourceMock,
                 var ownerResourceMock) = CreateTestObjects(todoDiscovery, personDiscovery, repoDbContextOptions: options);
 
@@ -125,33 +119,38 @@ public void BeforeUpdate_Without_Parent_Hook_Implemented()
                 It.IsAny<IUpdatedRelationshipHelper<Person>>(),
                 ResourceAction.Patch),
                 Times.Once());
-
             ownerResourceMock.Verify(rd => rd.BeforeImplicitUpdateRelationship(
                 It.Is<IUpdatedRelationshipHelper<Person>>(rh => PersonCheck(lastName + lastName, rh)),
                 ResourceAction.Patch),
                 Times.Once());
-
             VerifyNoOtherCalls(todoResourceMock, ownerResourceMock);
         }
 
         [Fact]
-        public void BeforeUpdate_Without_Child_Hook_Implemented()  // TODO l=3 implicit needs to be tested here too
+        public void BeforeUpdate_Without_Child_Hook_Implemented()
         {
             // arrange
             var todoDiscovery = SetDiscoverableHooks<TodoItem>(AllHooks, EnableDbValuesEverywhere);
             var personDiscovery = SetDiscoverableHooks<Person>(NoHooks);
-
             (var contextMock, var hookExecutor, var todoResourceMock,
                 var ownerResourceMock) = CreateTestObjects(todoDiscovery, personDiscovery, repoDbContextOptions: options);
 
             // act
             hookExecutor.BeforeUpdate(todoList, ResourceAction.Patch);
+
+            // assert
+            todoResourceMock.Verify(rd => rd.BeforeUpdate(It.Is<EntityDiff<TodoItem>>((diff) => TodoCheck(diff, description)), ResourceAction.Patch), Times.Once());
+            todoResourceMock.Verify(rd => rd.BeforeImplicitUpdateRelationship(
+                It.Is<IUpdatedRelationshipHelper<TodoItem>>(rh => TodoCheck(rh, description + description)),
+                ResourceAction.Patch),
+                Times.Once());
+            VerifyNoOtherCalls(todoResourceMock, ownerResourceMock);
         }
 
         [Fact]
         public void BeforeUpdate_NoImplicit()
         {
-
+            // arrange
             var todoDiscovery = SetDiscoverableHooks<TodoItem>(AllHooksNoImplicit, new ResourceHook[] { ResourceHook.BeforeUpdate });
             var personDiscovery = SetDiscoverableHooks<Person>(AllHooksNoImplicit, new ResourceHook[] { ResourceHook.BeforeUpdateRelationship });
             (var contextMock, var hookExecutor, var todoResourceMock,
@@ -167,7 +166,6 @@ public void BeforeUpdate_NoImplicit()
                 It.IsAny<IUpdatedRelationshipHelper<Person>>(),
                 ResourceAction.Patch),
                 Times.Once());
-
             VerifyNoOtherCalls(todoResourceMock, ownerResourceMock);
         }
 
@@ -198,7 +196,6 @@ public void BeforeUpdate_NoImplicit_Without_Child_Hook_Implemented()
             // arrange
             var todoDiscovery = SetDiscoverableHooks<TodoItem>(AllHooksNoImplicit, new ResourceHook[] { ResourceHook.BeforeUpdate });
             var personDiscovery = SetDiscoverableHooks<Person>(NoHooks);
-
             (var contextMock, var hookExecutor, var todoResourceMock,
                 var ownerResourceMock) = CreateTestObjects(todoDiscovery, personDiscovery, repoDbContextOptions: options);