fix: load db values for guid models

Author: maurei

src/JsonApiDotNetCore/Data/DefaultEntityRepository.cs

@@ -36,6 +36,28 @@ IDbContextResolver contextResolver
         { }
     }
 
+    public class DefaultGuidEntityRepository<TEntity>
+    : DefaultEntityRepository<TEntity, Guid>,
+    IGuidEntityRepository<TEntity>
+    where TEntity : class, IIdentifiable<Guid>
+    {
+        public DefaultGuidEntityRepository(
+            IJsonApiContext jsonApiContext,
+            IDbContextResolver contextResolver
+            )
+        : base(jsonApiContext, contextResolver)
+        { }
+
+        public DefaultGuidEntityRepository(
+            ILoggerFactory loggerFactory,
+            IJsonApiContext jsonApiContext,
+            IDbContextResolver contextResolver
+            )
+        : base(loggerFactory, jsonApiContext, contextResolver)
+        { }
+    }
+
+
     /// <summary>
     /// Provides a default repository implementation and is responsible for
     /// abstracting any EF Core APIs away from the service layer.

src/JsonApiDotNetCore/Data/IEntityReadRepository.cs

@@ -12,6 +12,11 @@ public interface IEntityReadRepository<TEntity>
        where TEntity : class, IIdentifiable<int>
     { }
 
+    public interface IGuidEntityReadRepository<TEntity>
+       : IEntityReadRepository<TEntity, Guid>
+       where TEntity : class, IIdentifiable<Guid>
+    { }
+
     public interface IEntityReadRepository<TEntity, in TId>
         where TEntity : class, IIdentifiable<TId>
     {
@@ -27,7 +32,7 @@ public interface IEntityReadRepository<TEntity, in TId>
         /// <summary>
         /// Apply fields to the provided queryable
         /// </summary>
-        IQueryable<TEntity> Select(IQueryable<TEntity> entities,List<string> fields);
+        IQueryable<TEntity> Select(IQueryable<TEntity> entities, List<string> fields);
 
         /// <summary>
         /// Include a relationship in the query

src/JsonApiDotNetCore/Data/IEntityRepository.cs

@@ -7,7 +7,7 @@ public interface IGuidEntityRepository<TEntity>
     : IEntityRepository<TEntity, Guid>
     where TEntity : class, IIdentifiable<Guid>
     { }
-
+     
     public interface IEntityRepository<TEntity>
         : IEntityRepository<TEntity, int>
         where TEntity : class, IIdentifiable<int>

src/JsonApiDotNetCore/Data/IEntityWriteRepository.cs

@@ -10,6 +10,11 @@ public interface IEntityWriteRepository<TEntity>
         where TEntity : class, IIdentifiable<int>
     { }
 
+    public interface IGuidEntityWriteRepository<TEntity>
+       : IEntityReadRepository<TEntity, Guid>
+       where TEntity : class, IIdentifiable<Guid>
+    { }
+
     public interface IEntityWriteRepository<TEntity, in TId>
         where TEntity : class, IIdentifiable<TId>
     {

src/JsonApiDotNetCore/Extensions/IServiceCollectionExtensions.cs

@@ -113,6 +113,7 @@ public static void AddJsonApiInternals(
                 AddOperationServices(services);
 
             services.AddScoped(typeof(IEntityRepository<>), typeof(DefaultEntityRepository<>));
+            services.AddScoped(typeof(IGuidEntityRepository<>), typeof(DefaultGuidEntityRepository<>));
             services.AddScoped(typeof(IEntityRepository<,>), typeof(DefaultEntityRepository<,>));
 
             services.AddScoped(typeof(ICreateService<>), typeof(EntityResourceService<>));

src/JsonApiDotNetCore/Graph/ServiceDiscoveryFacade.cs

@@ -40,10 +40,13 @@ public class ServiceDiscoveryFacade
 
         internal static HashSet<Type> RepositoryInterfaces = new HashSet<Type> {
             typeof(IEntityRepository<>),
+            typeof(IGuidEntityRepository<>),
             typeof(IEntityRepository<,>),
             typeof(IEntityWriteRepository<>),
+            typeof(IGuidEntityWriteRepository<>),
             typeof(IEntityWriteRepository<,>),
             typeof(IEntityReadRepository<>),
+            typeof(IGuidEntityReadRepository<>),
             typeof(IEntityReadRepository<,>)
         };
 

src/JsonApiDotNetCore/Hooks/ResourceHookExecutor.cs

@@ -71,7 +71,6 @@ void RecursiveBeforeRead(ContextEntity contextEntity, List<string> relationshipC
 
                 RecursiveBeforeRead(_graph.GetContextEntity(relationship.DependentType), relationshipChain, pipeline, calledContainers);
             }
-
         }
 
         public virtual IEnumerable<TEntity> BeforeUpdate<TEntity>(IEnumerable<TEntity> entities, ResourceAction pipeline) where TEntity : class, IIdentifiable
@@ -195,7 +194,6 @@ public virtual IEnumerable<TEntity> BeforeDelete<TEntity>(IEnumerable<TEntity> e
                 }
             }
             return entities;
-
         }
 
         public virtual IEnumerable<TEntity> OnReturn<TEntity>(IEnumerable<TEntity> entities, ResourceAction pipeline) where TEntity : class, IIdentifiable
@@ -382,7 +380,6 @@ Dictionary<RelationshipProxy, List<IIdentifiable>> LoadImplicitlyAffected(
             return implicitlyAffected.ToDictionary(kvp => kvp.Key, kvp => new HashSet<IIdentifiable>(kvp.Value).ToList());
         }
 
-
         IList LoadDbValues(IList entities, List<RelationshipProxy> relationships, Type entityType, ResourceHook hook)
         {
             if (_meta.ShouldLoadDbValues(entityType, hook))
@@ -393,7 +390,6 @@ IList LoadDbValues(IList entities, List<RelationshipProxy> relationships, Type e
             return null;
         }
 
-
         /// <summary>
         /// checks that the collection does not contain more than one item when
         /// relevant (eg AfterRead from GetSingle pipeline).

src/JsonApiDotNetCore/Hooks/TreeTraversal/HookExecutorHelper.cs

@@ -178,7 +178,6 @@ IEntityReadRepository<TEntity, TId> GetRepository<TEntity, TId>() where TEntity
         {
             var openType = typeof(TId) == typeof(Guid) ? typeof(IGuidEntityRepository<>) : typeof(IEntityRepository<>);
             return _genericProcessorFactory.GetProcessor<IEntityReadRepository<TEntity, TId>>(openType, typeof(TEntity));
-
         }
 
     }