feature: update repo #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
suggested changes
Dec 30, 2020
src/JsonApiDotNetCore.MongoDb/Extensions/MongoIQueryableExtensions.cs
Outdated
Show resolved
Hide resolved
|
I think I addressed all the comments. Let me know if there is anything else for me to do! By the way @bart-degreed , you have no idea how much I've learnt from your comments in both this repo and JsonApiDotNetCore so thanks a lot for that! |
bart-degreed
reviewed
Jan 1, 2021
bart-degreed
suggested changes
Jan 1, 2021
There was a problem hiding this comment.
By the way @bart-degreed , you have no idea how much I've learnt from your comments in both this repo and JsonApiDotNetCore so thanks a lot for that!
Thank you, that's really great to hear! Got a few more remarks, would be nice if you can take a look at them.
|
@bart-degreed I've just added you as an owner of the package on NuGet and did the changes you requested in your last review. |
bart-degreed
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
As @bart-degreed suggested in #2 , this PR is the first one of at least three that will come. This one contains only the update to the latest version of JADNC and the new implementation of
MongoEntityRepositorythat comes with it.For reference, I quote:
Let me know if I need to polish anything before moving on to the second PR, I'll try to have it all ready ASAP :)