-
Notifications
You must be signed in to change notification settings - Fork 480
Add = as problematic character and in proposed fix #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
Maybe we can remove some of the text here and point to http://api.jquery.com/category/selectors/ instead, which has the complete list? Also as of jQuery 3.0 (releasing soon) there is a function to escape these for you, it could be mentioned: https://jquery.com/upgrade-guide/3.0/#feature-new-method-jquery-escapeselector |
Of course not; I've already updated the PR. |
I already did. For all my email addresses that are registered with / used by GitHub. For some even twice. |
Thank you for the quick reply. I'm going to check what was the issue. |
Hi @db6edr. So the problem with your commit can be seen here. I'm also reporting it below:
|
HTML5 allows far more characters for the id attribute than does HTML4. Some of these now-valid characters lead to a syntax error when used with jQuery. The equals sign = is one of these.
Thanks for the clarification, I've updated the commits. |
@dmethvin are you happy with the changes? I think the PR is good to be merged. |
LGTM, thanks! |
Merged, thank you. |
HTML5 allows far more characters for the id attribute than does HTML4. Some of these now-valid characters lead to a syntax error when used with jQuery. The equals sign = is one of these. Closes gh-716
HTML5 allows far more characters for the id attribute than does HTML4. Some of these now-valid characters lead to a syntax error when used with jQuery. The equals sign = is one of these.