Skip to content

Add = as problematic character and in proposed fix #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add = as problematic character and in proposed fix #716

wants to merge 2 commits into from

Conversation

db6edr
Copy link
Contributor

@db6edr db6edr commented May 26, 2016

HTML5 allows far more characters for the id attribute than does HTML4. Some of these now-valid characters lead to a syntax error when used with jQuery. The equals sign = is one of these.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@dmethvin
Copy link
Member

Maybe we can remove some of the text here and point to http://api.jquery.com/category/selectors/ instead, which has the complete list? Also as of jQuery 3.0 (releasing soon) there is a function to escape these for you, it could be mentioned: https://jquery.com/upgrade-guide/3.0/#feature-new-method-jquery-escapeselector

@AurelioDeRosa
Copy link
Member

I agree with @dmethvin here. In the linked page we have all the text we need except for the mention of the escapeSelector() method which I'll add as soon as jQuery 3 is released. @db6edr do you mind updating your PR?

@db6edr
Copy link
Contributor Author

db6edr commented May 31, 2016

Of course not; I've already updated the PR.

@AurelioDeRosa
Copy link
Member

Hi @db6edr.

You also need to sign the CLA for the PR to be merged.

@db6edr
Copy link
Contributor Author

db6edr commented May 31, 2016

I already did. For all my email addresses that are registered with / used by GitHub. For some even twice.

@AurelioDeRosa
Copy link
Member

Thank you for the quick reply. I'm going to check what was the issue.

@AurelioDeRosa
Copy link
Member

Hi @db6edr. So the problem with your commit can be seen here. I'm also reporting it below:

Dirk Räder db6edr@users.noreply.github.com: db6edr@users.noreply.github.com is a private GitHub email address, which we can't accept since it can't be contacted. Please update your commit to another email address, and sign again with that address.

db6edr added 2 commits May 31, 2016 16:10
HTML5 allows far more characters for the id attribute than does HTML4. Some of these now-valid characters lead to a syntax error when used with jQuery. The equals sign = is one of these.
@db6edr
Copy link
Contributor Author

db6edr commented May 31, 2016

Thanks for the clarification, I've updated the commits.

@AurelioDeRosa
Copy link
Member

AurelioDeRosa commented May 31, 2016

@dmethvin are you happy with the changes? I think the PR is good to be merged.

@dmethvin
Copy link
Member

LGTM, thanks!

@AurelioDeRosa
Copy link
Member

Merged, thank you.

Krinkle pushed a commit that referenced this pull request Apr 9, 2024
HTML5 allows far more characters for the id attribute than does HTML4. Some of these now-valid characters lead to a syntax error when used with jQuery. The equals sign = is one of these.

Closes gh-716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants