Resizable: correct aspectRatio handling with min/max dimensions - Fixed #4951 #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Jeff |
|
I would love to see this added |
…- Autocomplete: Default autoFocus to true
…81 - Slider: value and values methods as setters aren't chainable.
…into petersendidit-tabs
… more useful than an incomplete listing of tests.
…ows only single year in year dropdown if numberOfMonths > 1.
… to properly handle them.
…abs: Rename select event to beforeActivate.
…ng onto multiple lines.
…ng onto multiple lines.
…31 - Tabs: Add beforeload event; deprecate ajaxOptions and cache options.
…ould be hidden when value is at 0%
…en value is at 0%
…quest background-image on resizable handles to work around an IE bug. Fixed #7233 - Resizable: resizable handles fail to work in IE if transparent and content overlaps
…e:url(about:blank) as it's shorter and safer. Thanks @epascarello . Better fixes #7233 - Resizable: resizable handles fail to work in IE if transparent and content overlaps
…ajaxOptions option.
creating the tooltip element on the fly, never reusing it. Use aria-describedby attribute to find the associated tooltip again. Allows customizing animations much easier (just replace fadeIn/fadeOut), still open. Updated demos and visual test to replace now-missing .widget() method. Added tooltipClass for that.
Fixes other popups to close. Also update aria usage.
… Incorrect dateFormat in jquery.ui.datepicker-nl.js.
…day name for Slovak localization.
skips the trigger.
… by actual icons support as part of menu.
… issue where the submenu jumped when mousing over the parent item's menu icon.
…7211 - Position: Collision: fit doesn't work at top of window when scrolled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resizable code did not handle aspectRatio + min/max dimension sizes correctly.
I corrected two issues:
The commit is https://github.com/jfremy/jquery-ui/commit/b63a3efbc46a2bca6ecdc1abaf20c4b3f16ecf59. It seems my pull request is including other commits but they've already been merged. I don't know enough about git to figure out why it's doing it.