fix offset top calculation #2057
Conversation
in _showDatepicker() we use native input.offsetHeight but in _checkOffset() we use jquery's input.outerHeight() jquery's method returns more accurate height for zoomed out pages. In result _checkOffset()'s `offset.top === ( inst.input.offset().top + inputHeight )` never returns true
|
|
Thanks for the report. Does the issue you describe exist when jQuery UI 1.12.1 is used or only with jQuery UI 1.13.0 or newer? |
|
the issue exist when jQuery UI 1.12.1 is used also |
There was a problem hiding this comment.
Thanks for the PR. We'll need tests for this change, though. Have a look at existing test in https://github.com/jquery/jquery-ui/tree/main/tests/unit/datepicker to see how to write one.
|
Also, we'll need you to sign the CLA to proceed. |
I'll look later about test. But not ready to sign anything because of 1 tiny patch. You can merge this fix from your name. |
|
I understand your position but we're obliged to require a CLA signature to accept contributions. If you're not willing to sign the CLA then it's better for someone else to look at it so that ownership is clear. Together with tests this would be much larger than just a single line changed. Given the above, I'm going to close this, sorry! |
See jquery#2057. This still needs merging.
in _showDatepicker() we use native input.offsetHeight
but in _checkOffset() we use jquery's input.outerHeight()
jquery's method returns more accurate height for zoomed out pages. In result _checkOffset()'s
offset.top === ( inst.input.offset().top + inputHeight )never returns true