All: Drop $.ui.escapeSelector in favor of $.escapeSelector #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
May 9, 2024
This dependency has been manually updated. `escape-selector` has been removed because jQuery UI is now using jQuery's built-in escape selector (available from version 3.0, which is required by Active Admin) - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork is bundling 1.13.2, but there has been a more recent release and I've preferred to manually update Ref activeadmin#8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
9 tasks
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
May 14, 2024
This dependency has been manually updated. `escape-selector` has been removed because jQuery UI is now using jQuery's built-in escape selector (available from version 3.0, which is required by Active Admin) - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork is bundling 1.13.2, but there has been a more recent release and I've preferred to manually update Ref activeadmin#8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
May 14, 2024
JavaScript files have been manually updated because: - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork of `jquery-ui-rails` is bundling 1.13.2, but there is a more recent version (1.13.3) `escape-selector` has been removed because jQuery UI is using jQuery's built-in escape selector. This selector is available from version 3.0, which is required by Active Admin, so it should not be a problem Ref activeadmin#8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
May 14, 2024
JavaScript files have been manually updated because: - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork of `jquery-ui-rails` is bundling 1.13.2, but there is a more recent version (1.13.3) `escape-selector` has been removed because jQuery UI is using jQuery's built-in escape selector. This selector is available from version 3.0, which is required by Active Admin, so it should not be a problem Ref activeadmin#8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
9 tasks
tagliala
added a commit
to activeadmin/activeadmin
that referenced
this pull request
May 15, 2024
Update vendored jquery-ui JavaScript files have been manually updated because: - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork of `jquery-ui-rails` is bundling 1.13.2, but there is a more recent version (1.13.3) `escape-selector` has been removed because jQuery UI is using jQuery's built-in escape selector. This selector is available from version 3.0, which is required by Active Admin, so it should not be a problem Ref #8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
cmanetta
pushed a commit
to bugcrowd/activeadmin
that referenced
this pull request
Jun 3, 2024
Update vendored jquery-ui JavaScript files have been manually updated because: - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork of `jquery-ui-rails` is bundling 1.13.2, but there is a more recent version (1.13.3) `escape-selector` has been removed because jQuery UI is using jQuery's built-in escape selector. This selector is available from version 3.0, which is required by Active Admin, so it should not be a problem Ref activeadmin#8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
4tolexx
pushed a commit
to velaluqa/activeadmin
that referenced
this pull request
Jul 6, 2024
Update vendored jquery-ui JavaScript files have been manually updated because: - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork of `jquery-ui-rails` is bundling 1.13.2, but there is a more recent version (1.13.3) `escape-selector` has been removed because jQuery UI is using jQuery's built-in escape selector. This selector is available from version 3.0, which is required by Active Admin, so it should not be a problem Ref activeadmin#8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14991