Menu: Account for scrollbars in jQuery 3.2 #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery >=3.2 doesn't include scrollbars in `.height()`, this commit switches it to `.innerHeight()` which does so in jQuery >=3.3. In jQuery 3.2 it doesn't either so include scrollbars in innerHeight, add it back. Using `.innerHeight()` instead of `.height()` should be fine as menu doesn't define padding styles.
dmethvin
approved these changes
Jul 19, 2020
fnagel
reviewed
Jul 20, 2020
| height = this.element.innerHeight(); | ||
|
|
||
| // jQuery 3.2 doesn't include scrollbars in innerHeight, add it back. | ||
| if ( $.fn.jquery.indexOf( "3.2." ) === 0 ) { |
There was a problem hiding this comment.
Because only 3.2 has this bug. See jquery/jquery#3589.
arschmitz
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery >=3.2 doesn't include scrollbars in
.height(), this commit switchesit to
.innerHeight()which does so in jQuery >=3.3. In jQuery 3.2 it doesn'teither so include scrollbars in innerHeight, add it back.
Using
.innerHeight()instead of.height()should be fine as menu doesn'tdefine padding styles.